Bug 144813 – app-misc/gcal-3.01-r2 does not use ISO 3166 country codes

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Ulrich Müller 2006-08-22 20:28:58 UTC]

gcal-3.01-r2 uses codes for country subdivisions that deviate from the standard codes of ISO 3166-2. For example, "Germany/Hesse" is represented by "DE_HS" but should be "DE_HE".

Attached patch fixes the problem for the Germany and Switzerland codes. (Similar issues may exist with the codes for Australia and Canada.)

[Comment 1 Ulrich Müller 2006-08-22 20:30:03 UTC]

Created attachment 94893 [details, diff]
gcal-3.01-iso3166.patch

[Comment 2 Ulrich Müller 2009-02-24 14:30:21 UTC]

Two and a half years have passed, so maybe it's time for a reminder. ;-)
Are there any objections against applying attached patch?

[Comment 3 Jeremy Olexa (darkside) (RETIRED) 2009-02-24 14:54:32 UTC]

(In reply to comment #2)
> Two and a half years have passed, so maybe it's time for a reminder. ;-)
> Are there any objections against applying attached patch?
> 

I don't see a problem. Have you queried upstream?

[Comment 4 Ulrich Müller 2009-02-24 15:08:23 UTC]

> Have you queried upstream?

Yes, and I've just sent a reminder.

[Comment 5 Jeremy Olexa (darkside) (RETIRED) 2009-02-24 15:43:53 UTC]

Ok.

Go for adding the patch to -r3 then, ~arch of course. Please be responsible for any issues and please add the upstream discussion/bug report to the URL field.

thx.

[Comment 6 Ulrich Müller 2009-02-26 06:56:49 UTC]

I've received an answer: The correct abbreviations are already in upstream's sources. And there will be a Gcal 4.00 release at some later time.

So I think it's safe to apply the patch, since it reflects upstream changes.

[Comment 7 Ulrich Müller 2009-02-26 21:51:27 UTC]

A fixed -r3 is in CVS.
- I've put the patch on Gentoo mirrors because of its size.
- Another small fix was necessary to make gcal build with current gettext.