Summary: | quake1-soa-1.ebuild (New Package) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Paul Bredbury <brebs> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | CONFIRMED --- | ||
Severity: | enhancement | CC: | bugzie, caibbor, iyosifov, nitro |
Priority: | High | Keywords: | EBUILD |
Version: | 2005.1 | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.idsoftware.com/games/quake/quake-mp1/ | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 144374 | ||
Attachments: |
quake1-soa-1.ebuild
quake1-soa-1.ebuild quake1-soa-1.ebuild quake1-armagon-data-1.0.ebuild quake1-soa-1.ebuild quake1-soa-1.ebuild games-fps/quake1-soa-1.ebuild games-fps/quake1-soa-1.ebuild |
Description
Paul Bredbury
2006-08-18 18:09:12 UTC
Created attachment 94568 [details]
quake1-soa-1.ebuild
Created attachment 94638 [details]
quake1-soa-1.ebuild
Added compatibility with a standard single-mission CD. Thanks to Piotr Szymaniak for testing.
Created attachment 94752 [details]
quake1-soa-1.ebuild
Moved the creation of the wrappers to the Quake engine ebuilds.
Created attachment 107324 [details]
quake1-armagon-data-1.0.ebuild
I've added things to this ebuild that I liked which were from the original bug
submitter's ebuild.
*** Bug 162268 has been marked as a duplicate of this bug. *** The naming convention for the ebuild is arguable, but there are precedents in the tree, e.g.: doom3-roe, doom3-mitm, doom3-lms. (In reply to comment #6) > The naming convention for the ebuild is arguable, but there are precedents in > the tree, e.g.: doom3-roe, doom3-mitm, doom3-lms. > I agree. though I like my name better, it should be consistent. feel free to modify my build or whatnot. there's just a couple things I like better in my build, and otherwise mine can be scrapped. I have a few concerns: 1.) I like to have absolute path/file names when copying documents (not like *.txt, etc) so that if its copying from a pre-existing install, it doesn't install other irrelevant crap that might be hanging out in the directory. 2.) I like that mine has the option to install from a preexisting installation (root path where the pak file is) 3.) I'm not sure what the license is. 4.) I really like hacing a CDROM_NAME_SET, as it makes the ebuild easier to interpret. if these concerns are addressed or debunked, my ebuild can be obsolete'd in favor of the former. and a checksum/md5sum to ensure that the correct pak0.pak is being copied would be a good idea. > 1.) I like to have absolute path/file names when copying documents (not like > *.txt, etc) The chances of the files in that directory being irrelevant are pretty slim. But yeah, you're right. IIRC, the text files are different depending on the CD. > 2.) I like that mine has the option to install from a preexisting installation > (root path where the pak file is) I don't think that will be used very often, and isn't worth adding as a standard, but if someone wants to improve the ebuild like that, then fine. > checksum/md5sum to ensure that the correct pak0.pak is being copied That's easy for 1 file, but I wouldn't like to write bash code to check the md5sums of ut2004-data's 2075 installed files :) Oh, and *quote* the variables, so we can have the remotest possibility of spaces/wotnot in files & dirs, without the scripts going wonky ;) Created attachment 107932 [details]
quake1-soa-1.ebuild
Merged both ebuilds into this one.
Kept the agreed upon ebuild name
Quoted all necessary variables
ditched the doc use flag
ditched the "local installation source" option
and probably some other things
Created attachment 107934 [details]
quake1-soa-1.ebuild
fixed some screw ups.
using newins instead of doins for pak0.pak file.
Created attachment 240157 [details]
games-fps/quake1-soa-1.ebuild
updated ebuild to include support for updated light maps. This works pretty much identically to the 'lights' USE flag in the darkplaces ebuild.
Created attachment 323834 [details]
games-fps/quake1-soa-1.ebuild
minor update: cdrom eclass now explicitly included, as required
|