Summary: | x11-misc/dmenu (new ebuild) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Cédric Krier <cedk> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | javism, tove, yamadharma |
Priority: | High | Keywords: | EBUILD, InOverlay |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.10kloc.org/dwm/ | ||
Whiteboard: | [sunrise-overlay] | ||
Package list: | Runtime testing required: | --- | |
Attachments: |
dmenu-0.2.ebuild
dmenu-0.2-config_mk.patch dmenu-0.2-makefile.patch |
Description
Cédric Krier
![]() Created attachment 93848 [details]
dmenu-0.2.ebuild
Created attachment 93849 [details]
dmenu-0.2-config_mk.patch
Created attachment 93850 [details]
dmenu-0.2-makefile.patch
src_compile() { if [ -f /etc/${P}/config.h ]; then einfo "Using /etc/${P}/config.h" cp /etc/${P}/config.h "${S}/config.h" fi [...] This is not correct. Have a look how it's done in sys-apps/busybox. Copying files from the "real" system into your sandbox is often a pita. This is now in the sunrise overlay. You can find it at: http://gentoo-sunrise.org/svn/reviewed/x11-misc/dmenu The ebuild uses the same way than busybox Update to dmenu 0.4 Tested on PPC FYI: The savedconfig stuff in busybox-1.2.1 has been changed (bug #143724). Ok, but I think it is not useful for this package In its current form it is wrong. I can't think of a valid use of ${S} is pkg_*. I put it into this bugreport because in this bugreport i told you that you can have a look how busybox saves the configuration. As you are using it in dwm too, you should fix dwm too. Ok, I misunderstood the issue, now I have fixed in sunrise Added my own version to the tree. It doesn't have the savedconfig flag, but if it's needed for a reason, file a new bug or poke me on IRC. |