Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 143354

Summary: x11-misc/dmenu (new ebuild)
Product: Gentoo Linux Reporter: Cédric Krier <cedk>
Component: New packagesAssignee: Default Assignee for New Packages <maintainer-wanted>
Status: RESOLVED FIXED    
Severity: enhancement CC: javism, tove, yamadharma
Priority: High Keywords: EBUILD, InOverlay
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://www.10kloc.org/dwm/
Whiteboard: [sunrise-overlay]
Package list:
Runtime testing required: ---
Attachments: dmenu-0.2.ebuild
dmenu-0.2-config_mk.patch
dmenu-0.2-makefile.patch

Description Cédric Krier gentoo-dev 2006-08-09 07:56:31 UTC
a generic, highly customizable, and efficient menu for the X Window System
Comment 1 Cédric Krier gentoo-dev 2006-08-09 07:57:06 UTC
Created attachment 93848 [details]
dmenu-0.2.ebuild
Comment 2 Cédric Krier gentoo-dev 2006-08-09 07:57:30 UTC
Created attachment 93849 [details]
dmenu-0.2-config_mk.patch
Comment 3 Cédric Krier gentoo-dev 2006-08-09 07:57:49 UTC
Created attachment 93850 [details]
dmenu-0.2-makefile.patch
Comment 4 Torsten Veller (RETIRED) gentoo-dev 2006-08-12 05:27:49 UTC
src_compile() {
	if [ -f /etc/${P}/config.h ]; then
		einfo "Using /etc/${P}/config.h"
		cp /etc/${P}/config.h "${S}/config.h"
	fi
[...]

This is not correct.
Have a look how it's done in sys-apps/busybox. Copying files from the "real" system into your sandbox is often a pita.
Comment 5 Cédric Krier gentoo-dev 2006-08-13 04:08:13 UTC
This is now in the sunrise overlay. You can find it at:
http://gentoo-sunrise.org/svn/reviewed/x11-misc/dmenu
Comment 6 Cédric Krier gentoo-dev 2006-08-13 04:08:51 UTC
The ebuild uses the same way than busybox
Comment 7 Cédric Krier gentoo-dev 2006-08-15 06:45:48 UTC
Update to dmenu 0.4
Comment 8 Javier Segura 2006-09-06 15:45:41 UTC
Tested on PPC
Comment 9 Torsten Veller (RETIRED) gentoo-dev 2006-09-08 05:49:54 UTC
FYI: The savedconfig stuff in busybox-1.2.1 has been changed (bug #143724).
Comment 10 Cédric Krier gentoo-dev 2006-09-08 06:23:02 UTC
Ok, but I think it is not useful for this package
Comment 11 Torsten Veller (RETIRED) gentoo-dev 2006-09-08 07:33:05 UTC
In its current form it is wrong. I can't think of a valid use of ${S} is pkg_*.

I put it into this bugreport because in this bugreport i told you that you can have a look how busybox saves the configuration. As you are using it in dwm too, you should fix dwm too.
Comment 12 Cédric Krier gentoo-dev 2006-09-08 10:41:09 UTC
Ok, I misunderstood the issue, now I have fixed in sunrise
Comment 13 David Shakaryan (RETIRED) gentoo-dev 2006-12-27 23:40:02 UTC
Added my own version to the tree. It doesn't have the savedconfig flag, but if it's needed for a reason, file a new bug or poke me on IRC.