| Summary: | iSight patch should not be applied by default in linux-uvc | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | kilian <kilian> |
| Component: | New packages | Assignee: | Stefan Schweizer (RETIRED) <genstef> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | zaai |
| Priority: | High | ||
| Version: | 2006.0 | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | patch to linux-uvc ebuild adding an isight USE flag | ||
|
Description
kilian
2006-08-08 05:15:16 UTC
I am wondering - can the patch maybe be changed to allow useage of all supported webcam models? Some if; else; calls should be enough. Not a lot of work to do .. I do not like to add another use flag - and I cannot maintain the other driver as I do not own the hardware. So for now I will leave it as-is - maybe you have a better patch or a better suggestion not including an use flag? > also adding an useflag would break current isight users - not an easy thing > to solve :(
I can't really understand why the USE-flag solution seems to worry you. USE flags are designed for this precise purpose: allowing to choose at compilation time what features will be included or not. Here, it's only a matter of adding a isight flag, which, if enabled, applies the iSight patch, making Mac users happy, and if not, avoid to apply it, making Logitech & co users happy too.
Current iSight users will just have to be sure the have enabled the isight USE flag before (re)emerging linux-uvc.
Please see the proposed patch.
Created attachment 93752 [details, diff]
patch to linux-uvc ebuild adding an isight USE flag
Vote +1 for the use flag. I've got a Logitech QuickCam Orbit MP which doesn't work with this ebuild because of this patch. Just wasted a day figuring out what was going on, then found this bug report (that'll teach me to check here first). Anyway, please resolve this soon. ok, you have persuaded me, I have commited it together with a new version - i hope I do not get problems with all the current users that I broke ;) Thanks for filing this bug anyway |
