| Summary: | stabilize x11-plugins/wmmixer-2.0_beta4-r1 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Denilson Sá Maia <denilsonsa> |
| Component: | Current packages | Assignee: | Gentoo Dockapp Team <desktop-dock> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mips |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Denilson Sá Maia
2006-08-03 08:19:08 UTC
It seems to memory related errors - usage of previously uninitialized pointers and addressing beyond initialized boundaries. I haven't time to fix all memory related errors but at least the first patch may be enough for clean run (tested with GCC 3.4.6):
In file 'theme.cc' comment out last two lines in Theme constructor:
Theme::Theme(const string& filename)
throw(InvalidThemeException)
{
...
// delete config;
// config = NULL;
}
In file 'dockapp.cc' in Dockapp constructor replace line 'icons_ = new unsigned[theme_->icon_num_];':
DockApp::DockApp(Mixer* mixer, int argc, char** argv, const string& display, const string& position, const string& theme_file, char x_flags) : mixer_(mixer), icons_(NULL)
{
...
icons_ = new unsigned[mixer->getNumChannels()];
...
}
In Portage (as new revision). Thanks for the submission, and even more for the patch! Since the current version (2.0_beta4) fails to run, and a newer version (2.0_beta4-r1) is available, I suggest marking it as stable. Maybe even remove the old version. Done (for x86). Other archs, please consider marking stable as well... Stable on SPARC mips never had this stable, closing a stale bug. |