Summary: | arpstar doesn't compile with 2.6.17 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | pharon |
Component: | Current packages | Assignee: | Gentoo Linux bug wranglers <bug-wranglers> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | ||
Priority: | High | ||
Version: | 2006.0 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
pharon
2006-08-01 08:38:03 UTC
I discovered arpstar today but unfortunately it doesn't compile with recent kernels. I am using 2.6.17-beyond2.2. The compile fails with this error: make -C /lib/modules/2.6.17-beyond2.2/build SUBDIRS=/root modules make[1]: Entering directory `/mnt/hda8/kernels/linux-2.6.17-beyond2.2' CC [M] /root/arpstar.o /root/arpstar.c:49: error: expected ) before string constant /root/arpstar.c:51: error: expected ) before string constant /root/arpstar.c:53: error: expected ) before string constant /root/arpstar.c:55: error: expected ) before string constant /root/arpstar.c:57: error: expected ) before string constant /root/arpstar.c: In function print_possible: /root/arpstar.c:602: warning: comparison of distinct pointer types lacks a cast make[2]: *** [/root/arpstar.o] Error 1 make[1]: *** [_module_/root] Error 2 make[1]: Leaving directory `/mnt/hda8/kernels/linux-2.6.17-beyond2.2' make: *** [default] Error 2 I made this small patch to fix the compilation : ######## --- arpstar.c 2005-03-04 05:42:13.000000000 +0200 +++ arpstar-patched.c 2006-08-01 18:29:14.000000000 +0300 @@ -44,7 +44,7 @@ ((unsigned char *)&addr)[3], \ ((unsigned char *)&addr)[4], \ ((unsigned char *)&addr)[5] - +/* static int verbose=0; MODULE_PARM (verbose,"i"); static char * trustedmac="000000000000"; @@ -55,6 +55,19 @@ MODULE_PARM (heal,"i"); static char * trustedip=""; MODULE_PARM (trustedip,"s"); +*/ +static int verbose=0; +static char * trustedmac="000000000000"; +static int coldrop=1; +static int heal=1; +static char * trustedip=""; + + +module_param(verbose, int, 0); +module_param(trustedmac, charp, "000000000000"); +module_param(coldrop, int, 1); +module_param(heal, int, 1); +module_param(trustedip, charp, ""); struct arpsentnode { ######## Not sure about the variable intialisation though. Can anybody please check? Does anybody know if this module actually works as advertised? I have read the technical descriptions, but I want real world reports from people using it. I will notify the authors about this bug as well. Thank you. |