Bug 142342 – shared-mime-info-0.17-r2: MP4 offset incorrect in freedesktop.org.xml

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Robin Ince 2006-07-31 14:57:54 UTC]

The /usr/share/mime/packages/freedesktop.org.xml file in shared-mime-info-0.17-r2 has an error in the MP4 section.

The offset attribute in the magic -> match entry should be 4, not 0.

<mime-type type="audio/mp4">
    <comment>MPEG-4 audio</comment>
    <comment xml:lang="bg">&#1040;&#1091;&#1076;&#1080;&#1086; &#1092;&#1072;&#1081;&#1083;, &#1092;&#1086;&#1088;&#1084;&#1072;&#1090; MPEG-4</comment>
    <comment xml:lang="de">MPEG-4-Audio</comment>
    <comment xml:lang="nb">MPEG-4-lyd</comment>
    <comment xml:lang="no">MPEG-4-lyd</comment>
    <alias type="audio/x-m4a"/>
    <magic priority="50">
<!-- WRONG:
      <match value="ftypM4A" type="string" offset="0"/>
-->
      <match value="ftypM4A" type="string" offset="4"/>
    </magic>
    <glob pattern="*.m4a"/>
  </mime-type>
  <mime-type type="video/mp4">

[Comment 1 foser (RETIRED) 2006-07-31 15:52:20 UTC]

This already got fixed in 0.18 afaics, can you confirm that ? Might be a good time to stabilize it.

[Comment 2 Robin Ince 2006-08-01 00:02:27 UTC]

It doesn't seem to be fixed in 0.18 (although there are some more translations):

  <mime-type type="audio/mp4">
    <comment>MPEG-4 audio</comment>
    <comment xml:lang="bg">&#1040;&#1091;&#1076;&#1080;&#1086;, &#1092;&#1086;&#1088;&#1084;&#1072;&#1090; MPEG-4</comment>
    <comment xml:lang="cs">Zvuk MPEG-4</comment>
    <comment xml:lang="de">MPEG-4-Audio</comment>
    <comment xml:lang="es">Audio MPEG-4</comment>
    <comment xml:lang="eu">MPEG-4 audioa</comment>
    <comment xml:lang="hu">MPEG-4-hang</comment>
    <comment xml:lang="it">Audio MPEG-4</comment>
    <comment xml:lang="ko">MPEG-4 &#50724;&#46356;&#50724;</comment>
    <comment xml:lang="nb">MPEG-4-lyd</comment>
    <comment xml:lang="nn">MPEG-4-lyd</comment>
    <comment xml:lang="sv">MPEG-4-ljud</comment>
    <comment xml:lang="uk">&#1047;&#1074;&#1091;&#1082; MPEG-4</comment>
    <comment xml:lang="vi">

[Comment 3 Robin Ince 2006-08-01 00:02:27 UTC]

It doesn't seem to be fixed in 0.18 (although there are some more translations):

  <mime-type type="audio/mp4">
    <comment>MPEG-4 audio</comment>
    <comment xml:lang="bg">&#1040;&#1091;&#1076;&#1080;&#1086;, &#1092;&#1086;&#1088;&#1084;&#1072;&#1090; MPEG-4</comment>
    <comment xml:lang="cs">Zvuk MPEG-4</comment>
    <comment xml:lang="de">MPEG-4-Audio</comment>
    <comment xml:lang="es">Audio MPEG-4</comment>
    <comment xml:lang="eu">MPEG-4 audioa</comment>
    <comment xml:lang="hu">MPEG-4-hang</comment>
    <comment xml:lang="it">Audio MPEG-4</comment>
    <comment xml:lang="ko">MPEG-4 &#50724;&#46356;&#50724;</comment>
    <comment xml:lang="nb">MPEG-4-lyd</comment>
    <comment xml:lang="nn">MPEG-4-lyd</comment>
    <comment xml:lang="sv">MPEG-4-ljud</comment>
    <comment xml:lang="uk">&#1047;&#1074;&#1091;&#1082; MPEG-4</comment>
    <comment xml:lang="vi">Âm thanh MPEG-4</comment>
    <alias type="audio/x-m4a"/>
    <magic priority="50">
      <match value="ftypM4A" type="string" offset="0"/>  <!---- Should be 4 -->
    </magic>
    <glob pattern="*.m4a"/>
  </mime-type>

[Comment 4 Robin Ince 2006-08-01 01:59:19 UTC]

I actually noticed this is wrong in the current freedesktop.org CVS:

http://webcvs.freedesktop.org/mime/shared-mime-info/freedesktop.org.xml.in?revision=1.155&view=markup

So I filed an upstream bug:

https://bugs.freedesktop.org/show_bug.cgi?id=7718

Would be nice to get it fixed quickly here though since it's such a trivial change.

[Comment 5 foser (RETIRED) 2006-08-03 10:24:51 UTC]

you are correct sir, I was mistakenly looking at the video/m4a bits.

[Comment 6 foser (RETIRED) 2006-08-03 11:22:40 UTC]

fixen in 0.18-r1

thanks for the report & fix