Bug 141344 – update of mozilla-firefox-2.0 beta2 patch

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Walter Meinl 2006-07-21 15:55:29 UTC]

Finally patches to fix the -enable-pango problems with gtk+-2.8 were fixed upstream see https://bugzilla.mozilla.org/show_bug.cgi?id=338446 and will be included in firefox-2.0_beta2 and also thunderbird. As I saw that a new ebuild exists for firefox-2.0_beta1, I wanted to post the upstream patch and the corresponding patch for ff-1.5.0.x (no checkin for that patch in MOZILLA_1_8_0_BRANCH is planned by upstream). These patches would replace 030_pango-cairo-1.patch (1.5.0.x) or 002_firefox-libdeps.patch and 030_pango-cairo-1.patch in the patchset for ff-2.0_beta2, respectively

[Comment 1 Walter Meinl 2006-07-21 15:57:51 UTC]

Created attachment 92455 [details]
patch for 1.5.0.x including patch for upstream bug332170

its already bzipped

[Comment 2 Walter Meinl 2006-07-21 16:01:32 UTC]

Created attachment 92456 [details, diff]
pango/gtk+2.8 patch for ff-2.0_beta2 as was merged upstream

[Comment 3 Piotr Jaroszyński (RETIRED) 2006-07-22 02:52:25 UTC]

No need to change the patches as they are doing exactly the same, but good to know that got fixed upstream.

[Comment 4 Walter Meinl 2006-07-22 07:55:17 UTC]

(In reply to comment #3)
> No need to change the patches as they are doing exactly the same,
The difference is that the patches here do not link agaginst pangocairo. Linking against pangocairo was never accepted upstream, and that's the reason why https://bugzilla.mozilla.org/show_bug.cgi?id=305185 was not checked in. The current gentoo patchsets do still use it. The reason for the past was clear there wasn*t an alternative, but that's changed. Anyway, it's your decision. 

[Comment 5 Walter Meinl 2006-07-26 16:16:15 UTC]

Don't understand, why this bug should depend on bug141791. The patches here are good for firefox thunderbird seamonkey and xulrunner, only xulrunner however needs an additional patch, but that has been taken care of in bug141791

[Comment 6 Walter Meinl 2006-09-01 13:34:42 UTC]

Comment on attachment 92456 [details, diff]
pango/gtk+2.8 patch for ff-2.0_beta2 as was merged upstream

is not needed anymore for ff-2.0_beta2

[Comment 7 Walter Meinl 2006-09-01 13:43:45 UTC]

Created attachment 95674 [details, diff]
updated firefox-libdeps.patch

Mozilla-Firefox-2.0_beta2 has arrived. As I built ff lately with intree-cairo I did not recognize that the patch for canvas is needed when building against system-cairo. I left a comment at https://bugzilla.mozilla.org/show_bug.cgi?id=344818
However we'll need only the patch for layout/build/Makefile.in 
The rest of the patch is obsolete Updated patch attached
Also 030_pango-cairo-patch-1 is not needed anymore simply remove it from mozilla-firefox-2.0_beta2-patches-1.3

[Comment 8 Walter Meinl 2006-09-02 14:49:44 UTC]

updating summary to address mozilla-firefox-2.0 beta2

[Comment 9 Stefan Schweizer (RETIRED) 2006-09-30 12:28:26 UTC]

thanks, I updated the patch for rc1. I very much appreciate that you care about our patchcount and apologize for forgetting it last time. Thank you again!