Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 140575

Summary: alsaplayer-0.99.76-r3 disables gtk support
Product: Gentoo Linux Reporter: Pablo Yanez Trujillo <shaoran>
Component: New packagesAssignee: Gentoo Linux bug wranglers <bug-wranglers>
Status: RESOLVED WONTFIX    
Severity: normal    
Priority: High    
Version: 2006.0   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: ebuild with with-gtk flag
the patch

Description Pablo Yanez Trujillo 2006-07-15 16:18:06 UTC
I've just made an update (emerge -uDN world) of the latest stable tree and alsaplayer was updated to version 0.99.76-r3. When I run alsaplayer I didn't have the gtk interface. So I checked whether this was my problem or not and I found out, that alsaplayer-0.99.76-r3.ebuild disables gtk with --disable-gtk.

Before reporting this bug I searched for similar bug reports and found at #125479 "so that we
can get rid of the (buggy) gtk interface. There are plenty of other players
using GTK interfaces, alsaplayer is still a decent player for commandline, but
it doesn't support unicode in the gtk1 support, and it's unmaintained upstream."

I think this ebuild should still have a gtk flag, perhaps not "gtk" if the there are big problems with it but "with-gtk" so that each user knows that he has to enable this flag before getting the gtk support. I created an ebuild with this new flag. I don't want to have an own alsaplayer ebuild in my overlay :)

patch:
--- alsaplayer-0.99.76-r3.ebuild        2006-07-16 01:15:13.000000000 +0200
+++ alsaplayer-0.99.76-r3.ebuild-new    2006-07-16 01:16:22.000000000 +0200
@@ -11,7 +11,7 @@
 LICENSE="GPL-2"
 SLOT="0"
 KEYWORDS="alpha amd64 ia64 ~mips ppc ~sparc x86"
-IUSE="alsa audiofile doc esd flac jack mikmod nas nls ogg opengl oss vorbis xosd"
+IUSE="alsa audiofile doc esd flac jack mikmod nas nls ogg opengl oss vorbis xosd with-gtk"
 
 RDEPEND=">=dev-libs/glib-1.2.10
        media-libs/libsndfile
@@ -25,6 +25,7 @@
        ogg? ( media-libs/libogg )
        opengl? ( virtual/opengl )
        vorbis? ( media-libs/libvorbis )
+       with-gtk? ( <x11-libs/gtk+-2 )
        xosd? ( x11-libs/xosd )"
 
 DEPEND="${RDEPEND}
@@ -58,6 +59,12 @@
                myconf="${myconf} --enable-oggflac"
        fi
 
+       if use with-gtk; then
+               myconf="${myconf} --enable-gtk"
+       else
+               myconf="${myconf} --disable-gtk"
+       fi
+
        econf \
                $(use_enable audiofile) \
                $(use_enable esd) \
@@ -71,7 +78,7 @@
                $(use_enable sparc) \
                $(use_enable vorbis oggvorbis) \
                ${myconf} \
-               --disable-gtk \
+               --disable-gtktest \
                --disable-sgi --disable-dependency-tracking \
                || die "econf failed"
Comment 1 Pablo Yanez Trujillo 2006-07-15 16:21:48 UTC
Created attachment 91837 [details]
ebuild with with-gtk flag
Comment 2 Pablo Yanez Trujillo 2006-07-15 16:23:28 UTC
Created attachment 91838 [details, diff]
the patch
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-07-15 16:24:15 UTC
No, it shouldn't, already stated on Bug 125479, it crashes like hell w/ gtk-1.2, and doesn't support a decent gtk version that's actually maintained upstream at all. Read Bug 125479, Comment #16. Sorry.
Comment 4 Pablo Yanez Trujillo 2006-07-15 16:30:51 UTC
I read all bug reports related with gtk and alsaplayer. I don't knwo if I had luck but I don't have crashes with alsaplayer. Let me know if there is now way that my changes in the tree so I can move my ebuild in my overlay

Thanks