Bug 140297

Summary:	hddtemp: improved option passing + safer defaults for daemon mode
Product:	Gentoo Linux	Reporter:	Marek Szuba <marecki>
Component:	New packages	Assignee:	Michal Januszewski (RETIRED) <spock>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	hddtemp-confext.patch

Description Marek Szuba (RETIRED) archtester

2006-07-13 21:53:01 UTC

Attached you will find a patch against /etc/(conf|init).d/hddtemp which does two things:

- the original conf.d file had key called HDDTEMP_OPTS which was in fact used to specify drives to monitor, although it was possible to use it for option passing too if one kept them in appropriate order. Now there are two separate keys, HDDTEMP_OPTS for command line options (parsed first in the init script) and HDDTEMP_DRIVES for drive names (parsed second). This should make it easier to avoid having someone put an option after the name of the disc and thus mess up the daemon's startup.

 - makes the aformentioned conf.d file make the daemon listen on loopback only by default. No point in having this class of information published to the whole network unless such behaviour is explicitly demanded by the user, especially in light of lack of authentication of the hddtemp protocol.

Comment 1 Marek Szuba (RETIRED) archtester

2006-07-13 21:53:58 UTC

Created attachment 91679 [details, diff]
hddtemp-confext.patch

Comment 2 Michal Januszewski (RETIRED) gentoo-dev

2006-07-14 18:12:30 UTC

I've added the changed files to CVS. Thanks :)