Summary: | libgphoto2 doesn't use USE_EXPAND | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | John Herdy <johnherdy> |
Component: | New packages | Assignee: | Alastair Tse (RETIRED) <liquidx> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | alonbl, bertrand, blubb, gentoo, gnome, lucamarturana, m.debruijne, rbu, zzam |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Other | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 157765 | ||
Attachments: | use_expand.patch |
Description
John Herdy
2006-07-10 07:29:20 UTC
Created attachment 95035 [details, diff]
use_expand.patch
I would also like to see libgphoto2 to use USE_EXPAND. It makes the selection more visible, is the de-facto standard and ensures that it gets rebuilt when --newuse is used and something changed. Attached is a patch which does everything needed. Note that you will have to discuss the addition of CAMERAS to the list of USE_EXPAND variables on gentoo-dev before applying this patch. Also not that I did not test it yet, that's up to you ;)
I tried the proposed patch on my system and all worked fine. I hope that this will be added in Portage. ping. Alastair, if you don't object within one week (or do it yourself of course), I will do this whenever I get to it. Well... A week passed... :) Simon... Please don't modify ebuild, refer to bug#157765. And I think you have a missing space in USE_EXPAND. Any time table? Since Alastiar seems not responing at all! > Any time table?
> Since Alastiar seems not responing at all!
Yes. Personally I won't do this until I have access to my devbox again, which is in February. Feel free to do it, though.
OT for Alon: Did you see the mail I sent you?
No response from list, I guess nobody mind... :) (In reply to comment #6) > No response from list, I guess nobody mind... :) > Thanks a lot Alon, it's really appreciated! |