Bug 139783

Summary:	eutils.eclass: ebeep / esleep never do something with portage 2.1
Product:	Gentoo Linux	Reporter:	Matthias Schwarzott <zzam>
Component:	Eclasses	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ciaran.mccreesh
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Matthias Schwarzott gentoo-dev

2006-07-09 09:09:21 UTC

The functions ebeep and esleep contain this check at the start:

--cut
if [ -z "$EBEEP_IGNORE" ] && [ -t 1 ] ; then
--cut

This check will fail always as [ -t 1 ] always deliver false in ebuilds with portage 2.1.
Checked with command tty shows that file-descriptor 1 is connected to a pseudo-terminal (/dev/pts/[0-9]+) now.

Solution: Either just remove the [ -t 1 ], or implement a better check for the existance of a propper output-device ( with attached user :) ).

Comment 1 Ciaran McCreesh 2006-07-15 06:55:23 UTC

Are you using that fancy new logging stuff?

Comment 2 Matthias Schwarzott gentoo-dev

2006-07-15 09:08:18 UTC

No, have not yet activated any new logging system.

Comment 3 Ciaran McCreesh 2006-07-15 10:08:08 UTC

Hrm. I guess 2.1 always uses the ugly tee hack, rather than just when running under Catalyst. Ok, someone should probably just nuke the -t check.

Comment 4 SpanKY gentoo-dev

2006-07-15 12:27:00 UTC

done, cheers