Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 138877

Summary: xen-sources-2.6.16.18 XEN_BLKDEV_TAP causes build failure
Product: Gentoo Linux Reporter: James Laver <james.laver>
Component: New packagesAssignee: Gentoo Xen Devs <xen>
Status: RESOLVED FIXED    
Severity: normal CC: james.laver, lorenzo
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 144994    
Attachments: My kernel config

Description James Laver 2006-07-02 09:30:17 UTC
drivers/xen/blktap/xenbus.c: In function `frontend_changed':
drivers/xen/blktap/xenbus.c:71: warning: passing arg 1 of `xenbus_exists' makes integer from pointer without a cast
drivers/xen/blktap/xenbus.c:71: error: too few arguments to function `xenbus_exists'
drivers/xen/blktap/xenbus.c:72: warning: passing arg 1 of `xenbus_rm' makes integer from pointer without a cast
drivers/xen/blktap/xenbus.c:72: error: too few arguments to function `xenbus_rm'
drivers/xen/blktap/xenbus.c:80: warning: passing arg 1 of `xenbus_gather' makes integer from pointer without a cast
drivers/xen/blktap/xenbus.c:96: warning: implicit declaration of function `xenbus_dev_ok'
drivers/xen/blktap/xenbus.c:101: error: too few arguments to function `xenbus_transaction_end'
drivers/xen/blktap/xenbus.c: In function `blkback_probe':
drivers/xen/blktap/xenbus.c:154: warning: passing arg 1 of `xenbus_gather' makes integer from pointer without a cast
drivers/xen/blktap/xenbus.c:163: warning: passing arg 1 of `xenbus_exists' makes integer from pointer without a cast
drivers/xen/blktap/xenbus.c:163: error: too few arguments to function `xenbus_exists'
make[3]: *** [drivers/xen/blktap/xenbus.o] Error 1
make[2]: *** [drivers/xen/blktap] Error 2
make[1]: *** [drivers/xen] Error 2
make: *** [drivers] Error 2

I'm going to attach my .config in my next comment
Comment 1 James Laver 2006-07-02 09:31:21 UTC
Created attachment 90701 [details]
My kernel config

I don't think it's got anything to do with my config, but i'm attaching in case
Comment 2 Chris Bainbridge (RETIRED) gentoo-dev 2006-07-02 12:15:31 UTC
Looks like a gcc problem... what version are you running?
Comment 3 James Laver 2006-07-02 12:32:15 UTC
localhost ~ # gcc -v
Reading specs from /usr/lib/gcc/i686-pc-linux-gnu/3.4.4/specs
Configured with: /var/tmp/portage/gcc-3.4.4-r1/work/gcc-3.4.4/configure --prefix=/usr --bindir=/usr/i686-pc-linux-gnu/gcc-bin/3.4.4 --includedir=/usr/lib/gcc/i686-pc-linux-gnu/3.4.4/include --datadir=/usr/share/gcc-data/i686-pc-linux-gnu/3.4.4 --mandir=/usr/share/gcc-data/i686-pc-linux-gnu/3.4.4/man --infodir=/usr/share/gcc-data/i686-pc-linux-gnu/3.4.4/info --with-gxx-include-dir=/usr/lib/gcc/i686-pc-linux-gnu/3.4.4/include/g++-v3 --host=i686-pc-linux-gnu --build=i686-pc-linux-gnu --disable-altivec --enable-nls --without-included-gettext --with-system-zlib --disable-checking --disable-werror --disable-libunwind-exceptions --disable-multilib --disable-libgcj --enable-languages=c,c++,f77 --enable-shared --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu
Thread model: posix
gcc version 3.4.4 (Gentoo 3.4.4-r1, ssp-3.4.4-1.0, pie-8.7.8)
Comment 4 Andrew Ross (RETIRED) gentoo-dev 2006-07-04 23:36:03 UTC
James, please post the output of "emerge --info".

There is an almost identical bug report upstream (http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=660) - the only difference is it's filed against 2.6.16.13 instead of 2.6.16.18
Comment 5 Andrew Ross (RETIRED) gentoo-dev 2006-07-05 00:35:29 UTC
I've replicated this problem on a few up-to-date x86 machines, and having inspected the code I can say that blktap.c is definately doing the wrong thing (ie. missing the required third argument to xenbus_exists).

James, if you unset CONFIG_XEN_BLKDEV_TAP you should be fine. Of course, without the front-end, there's little point building the backend driver, so you might also want to unset CONFIG_XEN_BLKDEV_TAP_BE .

While this could be resolved as UPSTREAM, we're still left with users potentially being bitten and reporting duplicate bugs.

Perhaps we can remove blktap, which appears to be broken and has been removed from xen-unstable (http://lists.xensource.com/archives/html/xen-changelog/2006-06/msg00137.html).

Alternatively, a least-effort approach could be adding a warning to the ebuild about blktap, but I think we'll find that some users will miss/ignore it and file duplicate bugs anyway.
Comment 6 James Laver 2006-07-05 04:40:01 UTC
As requested, attaching --info. I'm also going to try your idea, will get back to you on that. Thanks

opiate app-editors # emerge --info
Portage 2.1.1_pre1-r5 (default-linux/x86/2006.0, gcc-3.4.4/vanilla, glibc-2.4-r3
, 2.6.17-gentoo i686)
=================================================================
System uname: 2.6.17-gentoo i686 Intel(R) Pentium(R) 4 CPU 2.40GHz
Gentoo Base System version 1.12.1
dev-lang/python:     2.4.3-r1
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     [Not Present]
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r2
sys-devel/gcc-config: 2.0.0_rc1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -pipe -mno-tls-direct-seg-refs"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib/mozilla/defaults/pref /usr/share/X11/xkb /usr/shar
e/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/eselect/compiler /etc/gconf /etc/terminfo"
CXXFLAGS="-O2 -march=pentium4 -pipe -mno-tls-direct-seg-refs"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig buildpkg distlocks metadata-transfer sandbox sfperms strict
"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/
distributions/gentoo"
LDFLAGS="-Wl,-O1,--strip-debug,--enable-new-dtags,--sort-common"
LINGUAS="uk en_GB"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress 
--force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/d
istfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp/portage"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 3dnow X alsa apache2 apm artworkextra artworkextras avi bash-completion
 berkdb bitmap-fonts cli crypt dri eds emboss encode esd fastcgi foomaticdb fort
ran gdbm gif gnome gpm gstreamer gtk gtk2 guile imlib isdnlog jpeg kde libg++ li
bwww mad mikmod mmx mmxext mono motif mp3 mpeg mysql ncurses nls nptl nptlonly o
ffensive ogg opengl oss pam pango par pcre pdflib perl png pppd python qt qt3 qt
4 quicktime readline reflection sdk sdl session skey spell spl sqlite sse sse2 s
sl tcpd truetype truetype-fonts type1-fonts udev unicode usb userlocales vorbis 
xml xmms xorg xv zlib elibc_glibc input_devices_keyboard input_devices_mouse ker
nel_linux linguas_uk linguas_en_GB userland_GNU video_cards_radeon video_cards_v
esa"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_RSYNC_
EXTRA_OPTS
Comment 7 James Laver 2006-07-05 04:53:47 UTC
Alright, I've rebuilt, unsetting those two values in the .config.

Now, It prompted me with a y/n for each related module, i've never had a makefile do that to me before, but it all built fine.

Thank you.
Comment 8 Micheal Marineau (RETIRED) gentoo-dev 2007-08-25 00:11:16 UTC
This kernel is long gone and current kernels appear to be fine, closing.