Bug 138731

Summary:	Fix check_disk in nagios-plugins-1.4.3 (patch from CVS HEAD)
Product:	Gentoo Linux	Reporter:	Milan Holzäpfel <mail>
Component:	Current packages	Assignee:	Gentoo Netmon project <netmon>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://nagiosplug.cvs.sourceforge.net/nagiosplug/nagiosplug/plugins/check_disk.c?r1=1.64&r2=1.65&diff_format=u
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch from CVS patch for the ebuild adding appropriate epatch

Description Milan Holzäpfel 2006-07-01 09:02:39 UTC

Hello, 

a bug is present in nagios-plugins-1.4.3 which makes the check_disk command fail when the -p option is used. 
(I forgot to save the output, so I took the output from <URL:http://permalink.gmane.org/gmane.linux.debian.devel.bugs.general/102457>)

| joostje <at> muso:/$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p /tmp
| INPUT ERROR: C_IDFP (0.000000) should be less than W_IDFP (0.0) and both should be between zero and 100 percent, inclusive for /tmp
| check_disk: Could not parse arguments
| Usage: check_disk -w limit -c limit [-p path | -x device] [-t timeout][-m] [-e] [-W limit] [-K limit] [-v] [-q]

The fix is already in CVS: <URL:http://nagiosplug.cvs.sourceforge.net/nagiosplug/nagiosplug/plugins/check_disk.c?r1=1.64&r2=1.65&diff_format=u>

I will attach the patch and the patch for the nagios-plugins-1.4.3.ebuild I used. 

Regards,
Milan

Comment 1 Milan Holzäpfel 2006-07-01 09:03:43 UTC

Created attachment 90621 [details, diff]
patch from CVS

patch from http://nagiosplug.cvs.sourceforge.net/nagiosplug/nagiosplug/plugins/check_disk.c?r1=1.64&r2=1.65&diff_format=u

Comment 2 Milan Holzäpfel 2006-07-01 09:05:06 UTC

Created attachment 90622 [details, diff]
patch for the ebuild adding appropriate epatch

patch for the ebuild adding appropriate epatch, in case it is useful for you

Comment 3 Lance Albertson (RETIRED) gentoo-dev

2006-07-18 09:31:09 UTC

Thanks! Fixed in cvs as -r1.