Bug 137997 – games.eclass is not multilib aware

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Michael Weyershäuser 2006-06-25 19:13:57 UTC]

The dogameslib function from the games.eclass installs libraries to /usr/games/lib64 on AMD64 systems. However only /usr/games/lib is included in LDPATH from /etc/env.d/90games. Only very few ebuilds use this function, but it should still be fixed. (I first came across this when messing around with bug 124299)

[Comment 1 SpanKY 2006-06-26 12:38:10 UTC]

hmm games.eclass is not setup for multilib atm

simply fixing the env.d is not enough

[Comment 2 Mr. Bones. (RETIRED) 2006-08-22 01:13:46 UTC]

patch from the amd64 guys would be welcome I guess.

[Comment 3 Chris Gianelloni (RETIRED) 2006-10-03 12:35:21 UTC]

Created attachment 98721 [details, diff]
games.eclass.diff

Mike: what else really needs to be done besides checking for a multilib profile and adjusting GAMES_LIBDIR appropriately?  This patch should take care of doing at least that.  Let me know if you think we should apply it, or what I need to change to make it better.

[Comment 4 Christoph Mende (RETIRED) 2006-10-03 12:57:43 UTC]

There's a small mistake in the patch, you export GAMES_LIBDIR:
+export GAMES_LIBDIR=${GAMES_LIBDIR:-/usr/games/$(get_libdir)}
but you're using GAMES_LIBDIRS (see the "S" behind "DIR") for LDPATH:
-LDPATH="${GAMES_LIBDIR}"
+LDPATH="${GAMES_LIBDIRS}"

[Comment 5 Chris Gianelloni (RETIRED) 2006-10-03 15:13:01 UTC]

That isn't a mistake.

[Comment 6 Chris Gianelloni (RETIRED) 2006-10-17 13:03:26 UTC]

Created attachment 99895 [details, diff]
games.eclass.diff

OK, so it would have helped if I would have tested that last patch.  This one works for me on both x86/amd64, as far as I can tell.

[Comment 7 Chris Gianelloni (RETIRED) 2006-10-18 15:47:05 UTC]

OK... Added (modifed) to games.eclass