Bug 137461 – smstools-2.2.1-r2.ebuild does not install all available files

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Scott McKenzie 2006-06-20 23:47:25 UTC]

Portage 2.1 (default-linux/x86/2005.1, gcc-3.4.6, glibc-2.3.6-r4, 2.6.14-hardened-r3 i686)
=================================================================
System uname: 2.6.14-hardened-r3 i686 Pentium II (Klamath)
Gentoo Base System version 1.6.14
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
dev-lang/python:     2.3.5-r2, 2.4.2
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     [Not Present]
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1-r2
sys-devel/gcc-config: 1.3.13-r2
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=pentium2 -mtune=pentium2 -Os -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/mail/dspam /var/run/dspam"
CONFIG_PROTECT_MASK="/etc/env.d /etc/gconf /etc/terminfo"
CXXFLAGS="-march=pentium2 -mtune=pentium2 -Os -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="http://mirror.internode.on.net/pub/gentoo/"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.au.gentoo.org/gentoo-portage"
USE="x86 apache2 apm avi berkdb bitmap-fonts cli crypt dbus dri eds emboss encode foomaticdb fortran gdbm gif gpm gstreamer hal ide imlib isdnlog jpeg libg++ libwww mad mikmod mmx motif mp3 mpeg ncurses nls nptl nptlonly ogg oggvorbis oss pam pcre perl png pppd python quicktime readline reflection session spell spl ssl tcpd threads tiff truetype-fonts type1-fonts userlocales vorbis xml2 xmms xorg xv zlib elibc_glibc kernel_linux userland_GNU"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Scott McKenzie 2006-06-20 23:57:40 UTC]

There are lots of useful scripts in the (surprise, surprise) scripts directory when the source code is unpacked.  Of these only sendsms, sms2html, sms2unicode and unicode2sms are installed by this ebuild.  Also these are all installed in /usr/bin.  I think they should go in /etc/smstools so that administrators can make changes to the scripts and they will survive an upgrade due to config protect.  The missing scripts are:
email2sms
hex2bin
hex2dec
mysmsd
sms
sms2xml
smsevent
smsresend
sql_demo

The other files that are missing are the HTML documentation files.  These can be installed with
dohtml ${S}/doc/* 
in src_install()

[Comment 2 Tony Vroon (RETIRED) 2006-06-21 02:07:02 UTC]

Shell scripts do not belong in /etc, they belong in /usr/bin as they are executables. Adding a section for the HTML documentation and examining the other scripts.

[Comment 3 Tony Vroon (RETIRED) 2006-06-21 02:41:56 UTC]

Created attachment 89704 [details, diff]
smstools.scripts.diff

[Comment 4 Tony Vroon (RETIRED) 2006-06-21 02:43:26 UTC]

(In reply to comment #1)
> email2sms
> hex2bin
> hex2dec

Now installed by the ebuild.

> mysmsd

Only applies to a specific situation, installed as documentation.

> sms

An initscript is already installed, not relevant.

> sms2xml
> smsevent
> smsresend
> sql_demo

Only applies to a specific situation, installed as documentation.

> The other files that are missing are the HTML documentation files.  These can
> be installed with
> dohtml ${S}/doc/* 
> in src_install()

Added. 

[Comment 5 Tony Vroon (RETIRED) 2006-06-21 03:09:54 UTC]

This is in portage as -r3. Thank you for your bug report :)