Summary: | parted-1.4.24-r2.ebuild --> parted-1.4.24-r3.ebuild (misc. fixes) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Matthew Kennedy <mbkennedy> |
Component: | New packages | Assignee: | Seemant Kulleen (RETIRED) <seemant> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mbkennedy |
Priority: | High | ||
Version: | 1.0 RC6 r14 | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | parted-1.4.24-r2-1.4.24-r3.patch |
Description
Matthew Kennedy
2002-03-28 02:18:49 UTC
Created attachment 445 [details, diff]
parted-1.4.24-r2-1.4.24-r3.patch
* fixed crazy python dependency (no such thing required to build or run parted)
* fixed nls? dep. for builtin case
* added missing documentation items
* fixed broken/naive checks for readline (and nls) use flags
* updated other dep versions
it's a sys-app though...
lol, I am shy of sys-apps at the moment as well. as a preliminary comment, I would say that the "nls? ()" in the DEPENDS section is superfluous,since DEPENDS are for packages that _need_ to be emerged and present on the system in order to even think about compiling. Similarly, RDEPENDS are what need to be emerged and present to run the package after a successful compile. so with "nls? ()" you check for nls in USE, and emerge nothing as a dependency. Especially in this case, where gettext is built-in regardless, the nls check in src_compile() will do just fine on its own. Nice fix, and the idea should probably be instituted on all the ebuilds like this. Thanks again :) |