Summary: | xen-tools-3.0.2-r1 fails to build with sys-fs/progsreiserfs-0.3.1 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | M. Edward Borasky <znmeb> |
Component: | New packages | Assignee: | Andrew Ross (RETIRED) <aross> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bg, ko08nz, xen |
Priority: | High | ||
Version: | 2006.0 | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=573 | ||
Whiteboard: | scheduled for -r4 | ||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge --info
a patch for reisermodules |
Description
M. Edward Borasky
2006-06-17 21:49:46 UTC
Created attachment 89442 [details]
emerge --info
Looks like the same problem was reported upstream and marked invalid because it worked for them on Debian - see http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=573 As far as I can tell, the problem is that pygrub (part of app-emulation/xen-tools) is expecting progsreiserfs v0.3.0, which provides /usr/include/dal/file_dal.h . The only version of progsreiserfs in portage is 0.3.1rc8, which provides /usr/include/dal/file.h instead of /usr/include/dal/file_dal.h and thus causes the build failure. I've checked the two files and, as you'd expect, they're different - the filename change is due to an API change (function names change eg from 'file_dal_open' to 'file_open'). Things are fine in Debian because they only provide the 0.3.0.x versions. I can replicate the build failure by installing sys-fs/progsreiserfs then attempting to install app-emulation/xen-tools. After uninstalling sys-fs/progsreiserfs, app-emulation/xen-tools builds fine. However, I don't have access to hardware with virtualization extensions, so can't test pygrub's functionality - I assume it will be missing support for reading partitions formatted as reiserfs. An easy solution is to make sys-fs/progsreiserfs-0.3.1 block app-emulation/xen-tools, but that's not particularly nice for users. A slightly better approach might be explicitly disabling reiserfs support in pygrub (which may require a patch to setup.py), and using ewarn to notify the user (to prevent bug reports about missing resierfs functionality). I think the ideal solution is an investigation of the API change between 0.3.0 and 0.3.1, and hopefully a backwards-compatible patch to http://lxr.xensource.com/lxr/source/tools/pygrub/src/fsys/reiser/reisermodule.c that allows it to function with either version. However, I'm not in a position to provide this. A more realistic solution would be the introduction of an ebuild for the 0.3.0 series of progsreiserfs, using the same libraries/headers-only approach of the 0.3.1rc8 ebuild. Created attachment 94557 [details, diff]
a patch for reisermodules
a patch to test
Hi I just posted a patch that at least compiles xen. Please test if it is also does what it should do. hmm i really understand nothing... is it a patch for xen or xen-tools? how could i do this correctly, please? (In reply to comment #4) > Hi I just posted a patch that at least compiles xen. Please test if it is also > does what it should do. > oki, it works with the patch. thank you Fixed in app-emulation/xen-tools-3.0.2-r4, thanks. |