Summary: | Building gimp-2.2.10 against libpng-1.2.10 fails | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | John Ross Hunt <john.ross.hunt> |
Component: | New packages | Assignee: | John N. Laliberte (RETIRED) <allanonjl> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bruno, bug.hunter, cbm, didier.fabert, jfindlay, kamensky.fb, kdvgent, keikoz, leszek, markknecht, nelchael, parmigio, sgs, teidakankan, yourcomrade |
Priority: | High | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 139146 | ||
Attachments: |
ebuild log
Patch for *destroy* functions |
Description
John Ross Hunt
2006-06-13 08:02:42 UTC
Created attachment 89045 [details]
ebuild log
Forgot to mention, builds find agains libpng-1.2.8-r1. Maybe this is fixed in gimp-2.2.11?
(In reply to comment #1) > Maybe this is fixed in gimp-2.2.11? Nope, at least not in my experience. I get the same errors. I had exactly the same error when compiling cups-1.1.23-r7. So http://bugs.gentoo.org/show_bug.cgi?id=136346 is a related bug to this one. Unfortunately the suggested solution in comment #2 of bug 136346 however does not work for compiling the Gimp. I get the same error, it's the same on 2.2.10, 2.2.9 and 2.2.8-r1 too. 2.2.6-r1 is the same. Created attachment 89259 [details, diff]
Patch for *destroy* functions
With the patch applied it seems to compile and work, could somebody else test it?
Btw, it's against gimp 2.2.10
(In reply to comment #6) > Created an attachment (id=89259) [edit] > Patch for *destroy* functions > > With the patch applied it seems to compile and work, could somebody else test > it? > Btw, it's against gimp 2.2.10 > Compiling and working fine with your patch. Thank you! (In reply to comment #6) > Btw, it's against gimp 2.2.10 The patch applies and compiles with Gimp 2.2.11. I can open and save PNGs with no problems. Thank you. *** Bug 136771 has been marked as a duplicate of this bug. *** *** Bug 136926 has been marked as a duplicate of this bug. *** works here with libpng-1.2.10 and gimp-2.2.10... thanks sorry i meant gimp-2.2.11 Thanks mates. The patch submitted works fine for me too with gimp-2.2.11 and libpng-1.2.10. What is the proper way to apply this patch? I manually edited the png.c file, and then ran make and make install in /var/tmp/portage/gimp-2.2.11/work/gimp-2.2.11. This worked -- the gimp runs and it's 2.2.11, but emerge -s or esearch tell me that I have 2.2.10 installed as latest version. I found info on diff/patch files, but could not figure out what to do with it. Maybe someone here would be kind and point me in the right direction? Also, can this fix be added to the portage so the problem does not come up in the future? I had this error in CUPS also. Thank you! Comment #14: the "proper" way is to add whats called an "overlay" and modify the ebuild to apply the patch before compiling. What you did was bypass the ebuild's install process (thats also why portage does not know about your installed gimp-2.2.11). If you don't wish to learn about overlays or how to modify ebuilds, then it would probably be best to wait for a friendly dev to modify the in-tree ebuild and close this bug (which I'm sure will happen soon for something high profile like gimp). Another proper way to apply patch without overlay ist: 1. Press ctrl+z after unpacking sources (on emerge) 2. apply patch (copy it to /var/tmp/portage ... plug-in directory, then cd r/tmp/portage ... plug-in directory -> then patch -Np1 -i patch.diff After it all you can resume your emerge with fg its simple and doesnt require any overlay ;) (In reply to comment #16) > After it all you can resume your emerge with fg > > its simple and doesnt require any overlay ;) > Works fine also with ebuild. Emerge as usual. The compilation will eventually fails. Do this ... 1) Patch the source in /var/tmp/package/gimp-2.2.11/work/... 2) #cd /usr/portage/media-gfx/gimp 3) #ebuild gimp-2.2.11.ebuild compile 4) #ebuild gimp-2.2.11.ebuild install 5) #ebuild gimp-2.2.11.ebuild qmerge and if you want to build the binaries (optional) 6) #ebuild gimp-2.2.11.ebuild package Doesn't require overlay too. media-gfx/gimp-2.2.11-r1 added with the attached patch, thanks. *** Bug 136995 has been marked as a duplicate of this bug. *** *** Bug 137027 has been marked as a duplicate of this bug. *** *** Bug 137186 has been marked as a duplicate of this bug. *** *** Bug 139142 has been marked as a duplicate of this bug. *** *** Bug 139632 has been marked as a duplicate of this bug. *** |