| Summary: | rox.eclass missing quotes | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Peter Hyman <pete4abw> |
| Component: | Eclasses | Assignee: | Daniel Black (RETIRED) <dragonheart> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | dragonheart |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 99711 | ||
| Attachments: |
rox.eclass
rox.eclass.diff |
||
Created attachment 88908 [details]
rox.eclass
corrects unquoted variable in -n test.
if [ -n "${KEEP_SRC}" ] instead of
if [ -n ${KEEP_SRC} ]
Created attachment 88944 [details, diff]
rox.eclass.diff
May as well go all the way. Tell me if I've "corrected" too far.
commited |
The following snippet results in incorrect evaluation of $KEEP_SRC. The variable should have been quoted. if [ -n ${KEEP_SRC} ]; then ( cd src make clean ) else rm -rf src fi