Bug 136234

Summary:	net-misc/nxserver-freenx-0.5.0.20060311-r1 -- patch to nxloadconfig to fix problems I found
Product:	Gentoo Linux	Reporter:	Clemmitt M. Sigler <cmsigler>
Component:	Current packages	Assignee:	Gentoo NX Server project <nx>
Status:	RESOLVED TEST-REQUEST
Severity:	normal
Priority:	High
Version:	2006.0
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to fix 2 probs. I think I found with nxloadconfig

Description Clemmitt M. Sigler 2006-06-09 16:58:02 UTC

Hi,

After I reemerged nxserver-freenx-0.5.0.20060311-r1, I wasn't able to run `nxsetup --install --setup-nomachine-key --clean --purge' successfully.  The failure messages were:

-----------------------
/usr/NX/bin/nxloadconfig: line 499: [: missing `]'
Error: Invalid value "PROXY_TCP_NODELAY="

  Errors occured during config check.
  Please correct the configuration file.
-----------------------

I've fixed the BASH problem with the closing "]" on line 499.  I'm not positive of the other "fix," which is to assign PROXY_TCP_NODELAY="1" as the default value in /usr/NX/bin/nxloadconfig.

As it's written, unless PROXY_TCP_NODELAY is 0 or 1 I think this script will exit with an error, so it may not setup the system correctly(?).

I'm attaching a patch for nxloadconfig to fix these things, YMMV.  HTH.

Comment 1 Clemmitt M. Sigler 2006-06-09 16:59:00 UTC

Created attachment 88806 [details, diff]
Patch to fix 2 probs. I think I found with nxloadconfig

Comment 2 Jon 2006-06-23 05:16:59 UTC

These look like upstream errors. Did you check the Mailing List for NX to see if these have already been posted? I will definitely include these fixes until upstream fixes them. But it seems as though Fabian disappeared again. :P

Thanks for the report.

Cheers.

Comment 3 Stuart Herbert (RETIRED) gentoo-dev

2006-11-13 00:15:34 UTC

Hi,

Many thanks for the patch.  I've bumped nxserver-freenx in Portage, which should fix these problems with nxloadconfig.  Could you test please, and let me know if there are any problems?

Best regards,
Stu