| Summary: | localmount: request for more robustness | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Mark Dominik Bürkle <dominik.buerkle> |
| Component: | [OLD] baselayout | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | uberlord |
| Priority: | High | Keywords: | InVCS |
| Version: | 2006.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
i dont see how it could be empty Well, NET_FS_LIST can only be empty by accident. :-/ Well - only a feature request, not really a bug, no need to really act upon it. :-) I see no harm in the patch, so I've added it to our SVN repo. Will be in baselayout-1.12.1 Fixed in baselayout-1.12.1 Thanks for fixing it. Have seen that a long time ago on ~x86, iirc. :-) Close/Fixed so it may be purged. |
Hi, if NET_FS_LIST is somehow empty then the whole "mount ..." command will fail because it's options are ending in "...,no". Having alternate Text when NET_FS_LIST is set would make it more robust. Kind regards, mdb # diff -wu /root/emerged_init.d_localmount /etc/init.d/localmount --- /root/emerged_init.d_localmount 2006-05-07 20:59:55.000000000 +0200 +++ /etc/init.d/localmount 2006-05-10 20:02:10.000000000 +0200 @@ -9,7 +9,7 @@ start() { # Mount local filesystems in /etc/fstab. ebegin "Mounting local filesystems" - mount -at noproc,noshm,no${NET_FS_LIST// /,no} -O no_netdev >/dev/null + mount -at noproc,noshm${NET_FS_LIST:+,no}${NET_FS_LIST// /,no} -O no_netdev >/dev/null eend $? "Some local filesystem failed to mount" # Make sure we insert usbcore if its a module #