Bug 131700 – media-sound/id3v2-0.1.11: fix compilation with --as-needed

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description TGL 2006-04-29 11:27:39 UTC]

Attached is a patch to fix compilation with LDFLAGS="-Wl,--as-needed". It changes the order of the objects and linked libs in the c++ call in the Makefile.

Error log:
c++ -Wl,-O1 -Wl,--as-needed -Wl,--sort-common -L/usr/local/lib/  -pedantic -Wall -lz -lid3 -g -o id3v2 convert.o list.o id3v2.o genre.o
convert.o: In function `ConvertTag(int, char**, int)':
/var/tmp/portage/id3v2-0.1.11/work/id3v2-0.1.11/convert.cpp:58: undefined reference to `ID3_Tag::ID3_Tag(char const*)'
/var/tmp/portage/id3v2-0.1.11/work/id3v2-0.1.11/convert.cpp:63: undefined reference to `ID3_Tag::Clear()'
/var/tmp/portage/id3v2-0.1.11/work/id3v2-0.1.11/convert.cpp:64: undefined reference to `ID3_Tag::Link(char const*, unsigned short)'
/var/tmp/portage/id3v2-0.1.11/work/id3v2-0.1.11/convert.cpp:68: undefined reference to `ID3_Tag::Update(unsigned short)'
/var/tmp/portage/id3v2-0.1.11/work/id3v2-0.1.11/convert.cpp:56: undefined reference to `ID3_Tag::~ID3_Tag()'
<...snip many more...>

[Comment 1 TGL 2006-04-29 11:28:00 UTC]

Created attachment 85777 [details, diff]
id3v2-0.1.11-fix-as-needed.patch

[Comment 2 TGL 2006-05-14 04:58:24 UTC]

Sent upstream:
http://sourceforge.net/tracker/index.php?func=detail&aid=1488284&group_id=4193&atid=304193

[Comment 3 Diego Elio Pettenò (RETIRED) 2006-05-14 05:16:32 UTC]

Thanks for the patch :)
I've anyway used a more intrusive patch to fix a few other problems with the build system, like using the right CC/CXX values and similar, should be all set now.