Bug 130523 – cisco-vpnclient-3des-4.8 should use the linux-mod eclass

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Mike Auty (RETIRED) 2006-04-19 14:23:01 UTC]

I realise that it doesn't appear to add much worth, but without inheritting the linux-mod eclass this package, which installs kernel modules, doesn't get added to the moduledb list, and hence breaks the module-rebuild package (or at least causes it not to remerge cisco-vpnclient-3des when asked to rebuild all modules).  I don't know what other effects adding linux-mod will have, or whether you'll have to do more work to get it to add to the moduledb.  Anyway, seeing as it's a pretty small issue I've given it a low priority, it'd just be nice that's all.  Thanks!

[Comment 1 Chris Gianelloni (RETIRED) 2006-04-19 16:11:11 UTC]

Got a patch?

[Comment 2 Mike Auty (RETIRED) 2006-04-19 16:14:23 UTC]

No, but I'm happy for you to leave it with me and I'll try and work one up over the weekend...  5:)

[Comment 3 Chris Gianelloni (RETIRED) 2006-04-19 17:19:34 UTC]

Sure.  I have no clue how that eclass works (because I haven't looked at it) so I'd definitely be interested in a patch.  I'll end up back-porting it to all of the older ebuilds.

[Comment 4 Mike Auty (RETIRED) 2006-04-21 14:23:16 UTC]

Created attachment 85148 [details, diff]
cisco-vpnclient-3des-4.8.00.0490-linux-mod.patch

Turns out, this is really easy.  Inherit linux-mod (which inherits linux-info, so we can remove that).  Then ensure that the pkg_postinst and pkg_postrm use the linux-mod version.  Since there's no postrm in this ebuild that's done automatically, so finally just inset linux-mod_pkg_postinst at the start of this pkg_postinst and we're done.  The module will be both registered and unregistered with the moduledb properly.  The only side effects are the the module dependencies and module conf stuff gets updated too, but that should be ok.  Lemme know if it causes any problems...  5:)

[Comment 5 Chris Gianelloni (RETIRED) 2006-05-30 14:01:42 UTC]

Fixed in CVS... thanks for the bug report and the patch!