Bug 13048 – ffmpeg-0.4.6.ebuild (Update)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Rene Wagner 2003-01-01 15:59:21 UTC]

Hi,

attached is a patch containing an ebuild of ffmpeg-0.4.6.

The current ffmpeg (-0.4.5.*) ebuild was not up to date and did not install 
libavcodec which is required by some audio/video encoding/decoding programs 
(like motion, which I wanted to install).

Also it didn't install the documentation of ffmpeg.

I had to include a patch to fix some issues (mainly DESTDIR) with the makefiles
of ffmpeg.

Finally, I also updated the description according to what I found on the 
author's website.

Regards,

Rene

[Comment 1 Rene Wagner 2003-01-01 16:06:54 UTC]

Created attachment 6896 [details]
ffmpeg.diff

$ diff -urN /usr/portage/media-video/ffmpeg
/usr/local/portage/media-video/ffmpeg > ffmpeg.diff

[Comment 2 Rene Wagner 2003-01-01 16:09:41 UTC]

Sorry, the command creating #6896 should have been:

$ diff -urN /usr/portage/media-video/ffmpeg . > /home/reno/ebuilds/ffmpeg.diff

Rene

[Comment 3 Joshua Brindle (RETIRED) 2003-01-04 12:40:17 UTC]

this patch isn't against 0.4.6 right?
i committed an 0.4.6 ebuild a couple days ago i think reflecting the 0.4.6 
release version. AFAIK they should all have been installing libavcodec (as i 
use ffmpeg to stream and it uses is). Let me know if you emerge 0.4.6 and 
there are still problems, or it you trace them down.. Thanks

[Comment 4 Rene Wagner 2003-01-04 13:18:04 UTC]

No, the patch is against what I believe is identical to current CVS (retrieved
via rsync).

http://cvs.gentoo.org/cgi-bin/viewcvs/gentoo-x86/media-video/ffmpeg/
does not list any ffmpeg-0.4.6.ebuild.

And no, the previous ebuilds
(http://cvs.gentoo.org/cgi-bin/viewcvs/gentoo-x86/media-video/ffmpeg/ffmpeg-0.4.5.20021212.ebuild?rev=1.3&content-type=text/vnd.viewcvs-markup
and 
http://cvs.gentoo.org/cgi-bin/viewcvs/gentoo-x86/media-video/ffmpeg/ffmpeg-0.4.5.ebuild?rev=1.9&content-type=text/vnd.viewcvs-markup)
did not install libavcodec.

libavcodec was compiled into ffmpeg and ffserver, but not installed as a shared
library (.so).

Of course that is not a problem if you just want to run ffmpeg and ffserver, 
but makes it impossible for other programs to use libavcodec.

Please have a real look at the patch as it does more than just install 
libavcodec.

Thanks,

Rene

[Comment 5 Joshua Brindle (RETIRED) 2003-01-04 15:06:06 UTC]

ah yes, my mistake, 0.4.6 is there now
please make 2 patches, one against the 0.4.6 ebuild, and the other against the 
ffmpeg-0.4.6 tar gz, also please comment explaining what the purpose of the 
changes (esp in the ffmpeg tar) are. Thanks and if we get this running and 
tested i might be able to make it stable before 1.4 final.. 

[Comment 6 Rene Wagner 2003-01-04 16:46:57 UTC]

Created attachment 6960 [details]
ffmpeg-0.4.6.ebuild.diff

$ diff -u /usr/portage/media-video/ffmpeg/ffmpeg-0.4.6.ebuild
ffmpeg-0.4.6.ebuild > /home/reno/ebuilds/ffmpeg-0.4.6.ebuild.diff

Just read the diff...

Rene

[Comment 7 Rene Wagner 2003-01-04 16:52:39 UTC]

Created attachment 6962 [details]
ffmpeg-0.4.6-Makefiles.diff

$ diff -urN ../ffmpeg-0.4.6.orig .

Basically this patch is neccessary because ffmpeg doesn't use autoconf and
stuff.
It enables DESTDIR and fixes a few other minor things.
See the diff for details.

Rene

[Comment 8 Rene Wagner 2003-01-04 16:57:41 UTC]

BTW...

Why did you remove nasm from DEPEND? I haven't found anything about that in the
ChangeLog...

What I've read in the ChangeLogs of other ebuilds makes me believe that html 
docs shouldn't be gzipped...
Maybe that should be addressed, too.

Regards,

Rene

[Comment 9 Joshua Brindle (RETIRED) 2003-01-04 17:13:55 UTC]

Patches merged, only change was in the this line
use doc && make -C doc all || die "make all in ./doc failed."
that won't work right if user doesn't have doc USE var, and since it isn't 
fatal anyway i dropped the die. libavcodec.so is definately installed now, 
hope everything works. 

[Comment 10 Joshua Brindle (RETIRED) 2003-01-04 17:15:15 UTC]

Oh, and on http://ffmpeg.sourceforge.net/changelog.html under ffmpeg-0.4.6 
point #2 is 
- recoded dct and motion vector search with gcc (no longer depends on nasm).