Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 130219

Summary: patch: halt.sh does not unmount in nesting order
Product: Gentoo Linux Reporter: Mark McKenna <mckenna>
Component: [OLD] baselayoutAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED INVALID    
Severity: major    
Priority: High    
Version: 2006.0   
Hardware: AMD64   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: context diff against halt.sh

Description Mark McKenna 2006-04-17 00:09:05 UTC
The halt command uses 'sort -ur' to sort the output of /proc/mounts; this sorts by the mount source rather than the mount point.  It should be 'sort -k2 -ur' to sort by the second field (mount point); this will put longer names first (and therefore presumably unmount nested entries before their parents).
Comment 1 Mark McKenna 2006-04-17 00:10:17 UTC
Created attachment 84818 [details, diff]
context diff against halt.sh
Comment 2 SpanKY gentoo-dev 2006-04-18 16:55:07 UTC
thanks, merged into svn
Comment 3 Roy Marples (RETIRED) gentoo-dev 2006-04-24 06:09:39 UTC
This bug is ok so invalid as awk only echos field 2, so there is no need to specify a key to sort on.
Comment 4 Roy Marples (RETIRED) gentoo-dev 2006-04-24 06:10:45 UTC
Spanky, you should know better than to blindly trust someone without testing it first. Then bugs like #131001 would never happen :P