| Summary: | xmms fails to find gtk+ with LDFLAGS="-Wl,--as-needed" | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | spamas <spamas> |
| Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | minor | CC: | flameeyes, gnome, metalgod, nichoj, rockoo, superrajula |
| Priority: | High | ||
| Version: | 2006.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 133818, 133819 | ||
| Bug Blocks: | 129413 | ||
| Attachments: |
make libgtk against libgdk
make libgtk link against libgdk - version 2 |
||
|
Description
spamas
2006-04-07 04:05:54 UTC
That's because of LDFLAGS="-Wl,--as-needed"... *** Bug 129114 has been marked as a duplicate of this bug. *** If you take a look at the config.log, you'll see: configure:9032: checking for GTK - version >= 1.2.2 configure:9139: gcc -o conftest -g -O2 -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -D_REENTRANT -Wl,--as-needed conftest.c -L/usr/lib -lgtk -lgdk -rdynamic -lgmodule -lgthread -lglib -lpthread -lXi -lXext -lX11 -lm >&5 configure:9142: $? = 0 configure:9144: ./conftest ./conftest: symbol lookup error: /usr/lib/libgtk-1.2.so.0: undefined symbol: gdk_root_window configure:9147: $? = 127 configure: program exited with status 127 My guess is that -lgdk needs to be in the gcc call before -lgtk. Unfortunately, I'm no good with autotools and pals, in order to change this. Adding flameeyes to the CC, because he is an as-needed ninja. I thought I already said this. GTK+ 1.2 does not work with --as-needed. The solution is not to change the order of linking of xmms but to fix GTK+ itself to link against libgdk and iirc to libpng. I might take a look but I'm not going to build GTK 1.2 here, sorry :) Created attachment 84635 [details, diff]
make libgtk against libgdk
The attached patch should correct the linking of libgtk as it adds -lgdk to the makefile. I hope this patch is correct. At least I can compile and run xmms fine with --as-needed enabled. gnome herd please give us some help here with gtk+1 Created attachment 84637 [details, diff]
make libgtk link against libgdk - version 2
I have not tried the patch since I'm in the middle of a world rebuild, but I'm getting the same gtk error with '--as-needed' with all (so far at least) media-plugins/xmms-<name-of-plugin> I've got installed, which wants to recompile. Why is this assigned to GNOME? sound/metalgod is responsible for xmms ... reassigning No patch against xmms necessary if following fixes applied: bug #133818 glib-1.2.10-r5 patch, fix up linking for --as-needed bug #133819 gtk+-1.2.10-r11 --as-needed fix add gnome peeps because this require changes to gtk afaik. The patches given in the bug-reports linked to in comment #11 indeed make that xmms compiles fine with the as-needed use-flag. Things appear to work fine as far as I can tell. ps) Before applying those patches emerging xmms failed with the error-message as given in the startpost. warning) emerging gtk+-1.2 in my case had problems with linguas settings in make.conf. I needed to add LINGUAS="en nl" temporarily to make it emerge. (There was a bugreport on that problem) *** Bug 144366 has been marked as a duplicate of this bug. *** *** This bug has been marked as a duplicate of 133819 *** |
