Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 129061

Summary: significant changes made to ebuild with version change.
Product: Gentoo Linux Reporter: genbug
Component: New packagesAssignee: Gentoo Linux bug wranglers <bug-wranglers>
Status: VERIFIED WORKSFORME    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description genbug 2006-04-06 13:51:23 UTC
rp-pppoe-3.7 was changed from v1.5 to v1.6 without a version increment .
Despite carrying the exact same number if now require manual deletion of /etc/init.d/rp-pppoe script and then installs a different setup without this script.

This is just sloppy and one of those annoying things that makes gentoo a PITA to maintain.

rebuilding an installed pkg should NOT require manual intervention and deletion of existing scripts to be replaced by a new one.

That should at least be flagged by a -r1 so that we know there is a change , can look up what it is and mask it if required.

Assuming that there is a worthwhile reason for the change, it would also mean we got a chance to update when it was available. If it has the same number it wont get picked up by portage at all.

It will only get picked up by emerge -e world, which is exactly the circumstance when we dont want the process halted with an error.


rp-pppoe is one of the packages I keep a close eye on because breakage can be very inconvenient. If there is an -r1 I can check it out.

Please ensure that changes are correctly indicated.

I see this went in on the first of April so let's assume it someone having a bit of a practical joke. At least if was fairly harmless.

It just meant today was wasted because the emerge -e stopped after about half an hour.

regards.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-04-06 14:10:36 UTC
There were no significant changes made, the ebuilds is not just informing people who are upgrading in case they still haven't deleted the stale init script. There's no reason to revbump this and annoy people who have alreayd upgraded, since there are absolutely no functionality changes.

http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-dialup/rp-pppoe/rp-pppoe-3.7.ebuild?r1=1.5&r2=1.6

> rebuilding an installed pkg should NOT require manual intervention and deletion
> of existing scripts to be replaced by a new one.

That's exactly why there's no reason to revbump this. The above change was done since some people failed to notice after 9 months (!) this change was done (see the related thread on gentoo-dev mailing list). Gentoo handbook describes how to setup ADSL networking correctly, refer to it if you have problems.

http://www.gentoo.org/doc/en/handbook/handbook-x86.xml?part=4&chap=3#doc_chap4
Comment 2 genbug 2006-04-06 14:54:49 UTC
Thanks for the explaination, I slightly misunderstood what it was doing.

If you mean the script is stale ie unused and redundant why is it not just deleted as is done by most packages?

>>The above change was done
>>since some people failed to notice after 9 months (!) this change was done >>(see the related thread on gentoo-dev mailing list). 

I only upgraded to 3.7 a couple of weeks back since it simply was not working last time I tried and I had to mask it. Was there some enotice that I missed?


>> Gentoo handbook describes how
>> to setup ADSL networking correctly, refer to it if you have problems.

No problems , adsl was and is working . Thanks.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-04-06 15:07:19 UTC
(In reply to comment #2)
> If you mean the script is stale ie unused and redundant why is it not just
> deleted as is done by most packages?

Nothing under CONFIG_PROTECT directories gets deleted by default, so - neither is that init script.

> I only upgraded to 3.7 a couple of weeks back since it simply was not working
> last time I tried and I had to mask it. Was there some enotice that I missed?

Well, you are really a bit late then... :)

21 Jun 2005; Alin Nastac <mrness@gentoo.org> -files/rp-pppoe.rc,
  rp-pppoe-3.5-r11.ebuild:
  Remove the rp-pppoe init script. The new way of using rp-pppoe is through
  adsl net module of the baselayout-1.11.12-r4.

Also it's been announced in the forums etc., but as said, long time ago. )
Comment 4 genbug 2006-04-06 16:51:14 UTC

>>Nothing under CONFIG_PROTECT directories gets deleted by default, so - neither
>>is that init script.

So should not that get picked up by etc-update then?

>>Well, you are really a bit late then... :)
when I find a package requires a disproportionate effort to get it working I re-evalute the need to upgrade it. If there is no important feature other than it's newness it gets masked until such time as there is a need for it and hopefully by then some of the problems will have been sorted out.


>>
21 Jun 2005; Alin Nastac <mrness@gentoo.org> -files/rp-pppoe.rc,
  rp-pppoe-3.5-r11.ebuild:
  Remove the rp-pppoe init script. The new way of using rp-pppoe is through
  adsl net module of the baselayout-1.11.12-r4.

Also it's been announced in the forums etc., but as said, long time ago. )
>>

I have over 500 pkgs on this system , I cant be scouring notes on all ebuilds every time I update a package. 

I use the forums when I have a specific issue or when I really , really have nothing else to do.

In any case stopping the ebuild from going ahead seems a bit heavy handed for what is apparently just an unused file. You said above there was not functional difference so there was no need to stop a build that would have succeeded from going ahead. My emerge -e world should not have stopped for this.

Gentoo has a bigger maintainance overhead than any other distro I have seen.
For gentoo to be maintainable there has to be std channels for communicating changes and ebuilds should not fail unless it is necessary.

If there are enough ppl not seeing to warant a mod to the ebuild, then it seems notification was lacking.

thanks for your comments.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2006-04-06 16:54:14 UTC
(In reply to comment #4)
> 
> >>Nothing under CONFIG_PROTECT directories gets deleted by default, so - neither
> >>is that init script.
> 
> So should not that get picked up by etc-update then?

No. There's nothing to update - once the script is gone, no updates are installed.