Bug 127136

Summary:	xorg-server-1.0.1-r4 compile error with -mno-sse
Product:	Gentoo Linux	Reporter:	gent_bz
Component:	[OLD] Unspecified	Assignee:	Gentoo X packagers <x11>
Status:	RESOLVED UPSTREAM
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	x86
OS:	Linux
URL:	https://bugs.freedesktop.org/show_bug.cgi?id=6346
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Fix for fbmmx.c to correctly handle include of xmmintrin.h

Description gent_bz 2006-03-21 19:18:50 UTC

Compiling xorg-server for a Duron (Morgan) box, my CFLAGS include -march=athlon -mno-sse because this processor does not support SSE instructions.  (this is a shortcoming in gcc's -march option, but that's a problem for another day and not strictly related to this bug).

The file xorg-server-1.0.1/fb/fbmmx.c contains flawed logic when it comes to #including SSE intrinsic definitions from xmmintrin.h, and this causes a compile time error when using -mno-sse.  The use of _mm_shuffle_pi16 and _MM_SHUFFLE from xmmintrin.h are correctly contained in #ifdef USE_SSE, but the #include is not.

The patch fixes this behaviour to allow compilation to proceed beyond fbmmx.c - I have not yet tested any further.

I suspect that this should be pushed upstream.

Comment 1 gent_bz 2006-03-21 19:19:52 UTC

Created attachment 82830 [details, diff]
Fix for fbmmx.c to correctly handle include of xmmintrin.h

Comment 2 Donnie Berkholz (RETIRED) gentoo-dev

2006-03-21 23:52:53 UTC

Indeed. Please file it upstream at bugs.freedesktop.org in the xorg product and post the URL here, so we can track it.

Thanks!

Comment 3 gent_bz 2006-03-22 00:59:16 UTC

https://bugs.freedesktop.org/show_bug.cgi?id=6346