Bug 126591

Summary:	xmms-ir-1.2.10 gcc-4.10 error (might be glibc 2.4-r1 as well)
Product:	Gentoo Linux	Reporter:	Matteo Azzali (RETIRED) <mattepiu>
Component:	[OLD] GCC Porting	Assignee:	Luis Medinas (RETIRED) <metalgod>
Status:	RESOLVED FIXED
Severity:	normal	CC:	b.jacques, halcy0n, metalgod, tcort
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	117482
Attachments:	remove static keywords Lifted from xmms patchset

Description Matteo Azzali (RETIRED) gentoo-dev

2006-03-17 14:02:28 UTC

ir.c:19: error: static declaration of 'keepGoing' follows non-static declaration
ir.h:53: error: previous declaration of 'keepGoing' was here
ir.c:22: error: static declaration of 'irapp_thread' follows non-static declaration
ir.h:52: error: previous declaration of 'irapp_thread' was here
make: *** [ir.lo] Error 1

emerge info:
------------------------------------------------------------------------------
Portage 2.1_pre6-r3 (default-linux/x86/2005.0, gcc-4.1.0, glibc-2.4-r1, 2.6.15-gentoo-r7 i686)
=================================================================
System uname: 2.6.15-gentoo-r7 i686 AMD Sempron(tm) Processor 3100+
Gentoo Base System version 1.12.0_pre16
dev-lang/python:     2.4.2-r1
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1-r2
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r3
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=athlon-xp -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/kde/3/share/config /usr/share/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=athlon-xp -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="ftp://ftp.solnet.ch/mirror/Gentoo/ http://ftp.heanet.ie/pub/gentoo/ http://gentoo.chem.wisc.edu/gentoo/ http://mirror.switch.ch/ftp/mirror/gentoo/"
LANG="it_IT@euro"
LINGUAS="it"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 3dnow 3dnowex 3dnowext X aalib acl acpi acpi4linux alsa apm audiofile avi berkdb bitmap-fonts bzip2 crypt cups curl divx4linux dri dts dvb dvd dvdr dvdread eds emboss encode esd exif expat ffmpeg flac foomaticdb fortran gdbm gif gimp glut gnome gphoto2 gpm gstreamer gtk gtk2 guile hal idn imagemagick imlib java joystick jpeg kde lcms libg++ libwww lirc live lm_sensors mad matroska mikmod mmx mmx2 mmxext mng motif mp3 mpeg ncurses nls nptl nptlonly nsplugin nvidia offensive ogg oggvorbis ogre opengl oss pam pcre pdflib perl png python qt quicktime readline real scanner sdl spell sse sse-filters sse2 ssl svga tcltk tcpd tiff truetype truetype-fonts type1-fonts unicode usb v4l v4l2 vorbis win32codecs wxgtk1 xcomposite xine xml2 xmms xscreensaver xv xvid xvmc zlib zvbi elibc_glibc input_devices_mouse input_devices_keyboard input_devices_wacom kernel_linux linguas_it userland_GNU video_cards_nvidia video_cards_nv video_cards_vesa video_cards_vga"
Unset:  ASFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, LC_ALL, LDFLAGS

Comment 1 Mark Loeser (RETIRED) gentoo-dev

2006-03-17 18:14:05 UTC

xmms-1.2.10-r15 works for me

Comment 2 Matteo Azzali (RETIRED) gentoo-dev

2006-03-18 02:47:50 UTC

OMG I'm sorry, I wrote xmms instead of xmms-ir (that's why version was 1.2.10 
without r15). I'll reopen changing the name, sorry again.

Comment 3 Bastiaan Jacques 2006-03-20 16:37:26 UTC

Created attachment 82725 [details, diff]
remove static keywords

This patch applies to xmms-1.2.10.

Comment 4 Matteo Azzali (RETIRED) gentoo-dev

2006-03-21 02:19:02 UTC

That patch applied to xmms-ir worked for me.

Comment 5 Mark Loeser (RETIRED) gentoo-dev

2006-03-30 10:20:35 UTC

Created attachment 83444 [details, diff]
Lifted from xmms patchset

This is how the xmms patchset handled it (and upstream I'm assuming)

Comment 6 Luis Medinas (RETIRED) gentoo-dev

2006-03-30 10:27:53 UTC

i'll commit this on the next patcheset. Thanks

Comment 7 Mark Loeser (RETIRED) gentoo-dev

2006-04-29 22:55:17 UTC

Metalgod: what's going on with this?

Comment 8 Thomas Cort (RETIRED) gentoo-dev

2006-05-23 22:00:15 UTC

(In reply to comment #7)
> Metalgod: what's going on with this?

Per MetalGOD's request in #gentoo-media, I'm fixing this bug.

(In reply to comment #6)
> i'll commit this on the next patcheset. Thanks

No new patchset is required. The patch halcy0n pointed to in comment #5 is in the gentoo patchset in 0001_all_cvs-20050526.patch. The xmms-ir ebuild didn't set PATCH_VER, so the patch wasn't applied when building xmms-ir.

I bumped xmms-ir-1.2.10 to -r1 and set PATCH_VER to 2.3.1.