| Summary: | Simplified warn_trampolines patch for gcc-4.1.0 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Kevin F. Quinn (RETIRED) <kevquinn> |
| Component: | [OLD] Development | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Tidier patch to add -Wtrampolines; replacement for 00_all_gcc-trampolinewarn.patch | ||
|
Description
Kevin F. Quinn (RETIRED)
2006-03-15 23:39:44 UTC
Created attachment 82266 [details, diff]
Tidier patch to add -Wtrampolines; replacement for 00_all_gcc-trampolinewarn.patch
Did this default to on before? I personally would prefer it to be off since it could break even more builds that use -Werror, and it would be nice to keep the default behaviour as close to upstream as possible. It did, yes; default was '1'. To change that, just remove the 'Init(1)' bit and it'll default to off. updated patch in cvs with this version Kevin: could you send a proper ChangeLog-ed version with the warning defaulting to off to gcc-patches and cc toolchain ? any questions, just grab me on irc ... Submission upstream is in progress, but obviously will default to off.
I think defaulting it to on for everyone is not a good idea. I think a better way to switch it on "by default" would be to add it to the specs; fex.
-------- Wtrampolines.specs --------
*cc1:
+ %{!Werror: -Wtrampolines}
-------------------------------------
which could be done by interested parties through GCC_SPECS, rather than forcing it to all users.
Now GCC_SPECS supports multiple entries, we could supply a whole range of useful little specs files like that, either along with the gcc ebuild or perhaps separately.
|