Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 125545

Summary: net-misc/rdesktop strips binary
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: Chris Gianelloni (RETIRED) <wolf31o2>
Status: RESOLVED FIXED    
Severity: minor CC: jakub
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2006-03-08 16:54:53 UTC
net-misc/rdesktop by default strips the rdesktop binary, making debug impossible also when built with -ggdb.

A simple sed -i -e 's:strip:true:' ${S}/Makefile.in before econf will fix it.

Thanks,
Diego
Comment 1 Chris Gianelloni (RETIRED) gentoo-dev 2006-03-16 13:09:37 UTC
Fixed in CVS... thanks for the bug report and the sed... making it all too easy one me, you know...
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-07-20 13:35:02 UTC
Doesn't work any more in 1.5.0_rc1.

QA Notice: pre-stripped files found:
/var/tmp/portage/rdesktop-1.5.0_rc1/image/usr/bin/rdesktop

A new patch:

--- rdesktop-1.5.0_rc1.ebuild.orig	2006-07-05 18:14:52.000000000 +0200
+++ rdesktop-1.5.0_rc1.ebuild	2006-07-20 22:33:19.000000000 +0200
@@ -33,7 +33,9 @@
 
 src_compile() {
 	sed -i -e '/-O2/c\' -e 'cflags="$cflags ${CFLAGS}"' configure
-	sed -i -e 's:strip:true:' Makefile.in
+	local strip="$(echo '$(STRIP) $(DESTDIR)$(bindir)/rdesktop')"
+	sed -i -e "s:${strip}::" Makefile.in \
+		|| die "sed failed in Makefile.in"
 	econf \
 		--with-openssl=/usr \
 		`use_with debug` \
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2006-07-20 15:42:22 UTC
Fixed in CVS... thanks for the patch...