Bug 125441 – Issues with mod_cband

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Michael Stewart (vericgar) (RETIRED) 2006-03-07 22:33:45 UTC]

mod_cband does not have a reasonable default config - all it does is load the module. At the minimum you should enable the status indicators. It would be best if you put the example configurations in the module configuration. Comment it out if you can't get it to work in a reasonable default way.

Also, when I tried installing it to see what it was about, it failed miserably. It tried to use apxs, when it should use apxs2. I took a look at the ebuild, and it appears it's using it's own ./configure and Makefile instead of using the eclass to compile it. I've made some changes in CVS so that it compiles and installs correctly using the eclass. Please review my changes, and let me know if you don't understand them, or would like to discuss them further.

Also, if you are going to maintain an apache module, it's highly suggested that your join the herd and bugzilla alias.

[Comment 1 Krzysztof Pawlik (RETIRED) 2006-03-08 02:56:45 UTC]

Created attachment 81675 [details]
files/10_mod_cband.conf

(In reply to comment #0)
> mod_cband does not have a reasonable default config - all it does is load the
> module. At the minimum you should enable the status indicators. It would be
> best if you put the example configurations in the module configuration. Comment
> it out if you can't get it to work in a reasonable default way.

Most of mod_cband configuration goes to per-vhost files, so it's only possible to have some simple example in 10_mod_cband.conf, I'm attaching a modified version of that file - is this version better?

> Also, when I tried installing it to see what it was about, it failed miserably.
> It tried to use apxs, when it should use apxs2. I took a look at the ebuild,
> and it appears it's using it's own ./configure and Makefile instead of using
> the eclass to compile it. I've made some changes in CVS so that it compiles and
> installs correctly using the eclass. Please review my changes, and let me know
> if you don't understand them, or would like to discuss them further.

Thanks.

> Also, if you are going to maintain an apache module, it's highly suggested that
> your join the herd and bugzilla alias.

Done.

[Comment 2 Jakub Moc (RETIRED) 2006-03-08 05:13:28 UTC]

Kinda nitpicking, but

- please, use example.com (net,org) in examples
- using default Gentoo location for DocumentRoot would be nice as well. Like:
# 	DocumentRoot /var/www/example.com
# 	ServerName vhost1.example.com

[Comment 3 Michael Stewart (vericgar) (RETIRED) 2006-03-08 07:38:18 UTC]

More nitpicking :)

Most of our module configuration files have a similar format as far as the IfDefine and IfModules go, generally like so:

<IfDefine MODNAME>
  <IfModule !mod_modname.c>
    LoadModule ....
  </IfModule>
</IfDefine>

<IfModule mod_modname.c>
 ...
</IfModule>

This is done like this mostly so that if the user has added a LoadModule line elsewhere this config doesn't cause an error about a module being loaded twice. It also enables the default module configuration if the module is loaded, instead of it depending on the -D MODNAME being enabled.

[Comment 4 Krzysztof Pawlik (RETIRED) 2006-03-16 09:43:59 UTC]

Created attachment 82308 [details]
files/10_mod_cband.conf

New version - is it ok?

[Comment 5 Michael Stewart (vericgar) (RETIRED) 2006-03-16 09:47:29 UTC]

Much better! Thanks!

[Comment 6 Krzysztof Pawlik (RETIRED) 2006-03-16 09:51:52 UTC]

Commited.