Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 124741

Summary: bash-completion's file in /etc/profile.d does not not match *.sh
Product: Gentoo Linux Reporter: Sven <sven.koehler>
Component: New packagesAssignee: Aaron Walker (RETIRED) <ka0ttic>
Status: RESOLVED WONTFIX    
Severity: normal CC: balaz, edvicif, flori, paddor, pyromancer
Priority: High    
Version: 2005.1   
Hardware: All   
OS: Other   
Whiteboard:
Package list:
Runtime testing required: ---

Description Sven 2006-03-02 22:52:19 UTC
Hi,

i just installed app-shells/bash-completion-20060301, and it installs the following file:

  /etc/profile.d/bash-completion

But that isn't worth anything, since in my /etc/profile it says:

for sh in /etc/profile.d/*.sh ; do
        if [ -r "$sh" ] ; then
                . "$sh"
        fi
done

This version of /etc/profile is from sys-apps/baselayout-1.11.14-r5

The file should be called
  /etc/profile.d/bash-completion.sh
instead of
  /etc/profile.d/bash-completion
Comment 1 Sven 2006-03-02 23:54:25 UTC
I just saw, that i'm instructed to add
  [ -f /etc/profile.d/bash-completion ] && . /etc/profile.d/bash-completion
to my bashrc

Well, but isn't /etc/profile.d for files that are automatically loaded by /etc/profile?

In addition, there is bash-completion-config to enable/disable things globally/user-wise - so i don't see any reason, why
  /etc/profile.d/bash-completion
shouldn't be renamed to
  /etc/profile.d/bash-completion.sh
and therefor be loaded automatically.
Comment 2 Aaron Walker (RETIRED) gentoo-dev 2006-03-03 09:29:46 UTC
No it should be disabled by default and only enabled if the user wants it.  As for bash-completion-config (which is deprecated in favor of eselect's bashcomp module) , it is only for enabling/disabling third party completion scripts (those installed into /usr/share/bash-completion) and has nothing to do with bash-completion proper.  Closing this as WONTFIX.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-07-31 12:49:47 UTC
*** Bug 142316 has been marked as a duplicate of this bug. ***
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2006-08-28 08:06:14 UTC
*** Bug 145360 has been marked as a duplicate of this bug. ***
Comment 5 Patrick Avery 2006-08-28 19:59:28 UTC
(In reply to comment #2)
> No it should be disabled by default and only enabled if the user wants it.  As
> for bash-completion-config (which is deprecated in favor of eselect's bashcomp
> module) , it is only for enabling/disabling third party completion scripts
> (those installed into /usr/share/bash-completion) and has nothing to do with
> bash-completion proper.  Closing this as WONTFIX.

Then shouldn't it be moved out of the /etc/profile.d directory?  It would be like storing optional environment variables under /etc/env.d...

Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-03-28 13:29:18 UTC
*** Bug 172553 has been marked as a duplicate of this bug. ***
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2007-06-12 20:00:09 UTC
*** Bug 181819 has been marked as a duplicate of this bug. ***
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2007-09-20 12:25:46 UTC
*** Bug 193167 has been marked as a duplicate of this bug. ***