Summary: | mutt-1.5.15 - sidebar patch | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Piotr Szymaniak <bugzie> |
Component: | New packages | Assignee: | Fernando J. Pereda (RETIRED) <ferdy> |
Status: | RESOLVED TEST-REQUEST | ||
Severity: | enhancement | CC: | louis, net-mail+disabled, patrik |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.lunar-linux.org/index.php?option=com_content&task=view&id=44 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
POOR mutt-sidebar/mutt-sidebar-1.5.11.ebuild
mutt-1.5.13-r1.ebuild with optional sidebar support mutt-1.5.13-sidebar.20061023.patch mutt-1.5.14-r1.ebuild with USE=sidebar and nntp conflict detection mutt-1.5.14-sidebar.patch |
Description
Piotr Szymaniak
2006-02-24 01:13:49 UTC
Created attachment 80579 [details] POOR mutt-sidebar/mutt-sidebar-1.5.11.ebuild My poor ebuild for this, and it is only an edit of this: http://www.gentoo.pl/~arsen/packs/mutt-sidebar-1.5.9.tar.gz (also a poor ebuild ;) I guess the information in this bug isn't really relevant anymore? My proposed solution is to have a USE="sidebar" in the original mutt ebuild and use the patch from http://lunar-linux.org/~tchan/mutt/patch-1.5.13.sidebar.20061023.txt It would be really sweet to have the sidebar, though.. Created attachment 104421 [details] mutt-1.5.13-r1.ebuild with optional sidebar support This is an ebuild that patches the current x86 ebuild of mutt with optional sidebar support. Sidebar patch taken from http://lunar-linux.org/index.php?page=mutt-sidebar Created attachment 104422 [details, diff]
mutt-1.5.13-sidebar.20061023.patch
The patch itself
That has to be worked out a bit more. The sidebar patch does NOT work with the nntp patch. I just applied it on top of our patchset and made it apply cleanly. However it is a suboptimal solution given the fact that the nntp and sidebar patches conflict both code and feature wise. - ferdy Can't this be solved like other ebuilds by spitting out an error if both use-flags are on and exiting with a message to the user to disable one of them? Or to print a warning saying sidebar support is disabled since the nntp use-flag is on and they can't co-exist? It's working perfectly with my setup (USE="berkdb crypt gdbm idn imap nls sasl sidebar ssl") and I wouldn't trade it for nntp.. ;) Created attachment 114055 [details] mutt-1.5.14-r1.ebuild with USE=sidebar and nntp conflict detection Since I'm starting to use mutt again and mutt-ng development has ceased, I took the effort to update sidebar support for Gentoo's mutt to 1.5.14. This new ebuild is based on the .14 one, but contains a new "sidebar" USE flag that will activate the sidebar patch (after all other patches). If both the sidebar and nntp flags are set, the script will die (using confutils_use_conflict from the confutils eclass). I also made some minor cleanup changes to the .14 ebuild (indentation and configure switches order). I'll post the updated patch (unmodified from upstream http://lunar-linux.org/index.php?page=mutt-sidebar) for .14 in a second. Created attachment 114057 [details]
mutt-1.5.14-sidebar.patch
The actual patch. Applies cleanly after the 01-06 chain from the Gentoo patches tarball and could be included there. You would then need to modify the ebuild to _remove_ the patch if the sidebar is not used (like the nntp USE flag already does with its patch).
I will try to integrate said patch on a revbump soon. - ferdy Ok, mutt-1.5.15 is here. This patch _will_ be part of our patchset for said version. Thanks guys, and sorry for not having it ready earlier. - ferdy It should be all set. Please test mutt-1.5.15 with USE="-vanilla" it should pull the sidebar patch with it. Until the mirrors propagate, you can (manually) get mutt-1.5.15-gentoo-patches.tar.bz2 from http://dev.gentoo.org/~ferdy/distfiles Enjoy it and let me know if it fails ! - ferdy |