Bug 123853

Summary:	media-gfx/cthumb-4.2: handle more gracefully missing image files
Product:	Gentoo Linux	Reporter:	Martin Mokrejš <mmokrejs>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED UPSTREAM
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	cthumb.in.patch

Description Martin Mokrejš 2006-02-23 13:35:00 UTC

$ cthumb file.lst
cthumb 4.2, running in /home/xxxx/blah
rdjpgcom: can't open p7050934.jpg
rdjpgcom: can't open p7050936.jpg
rdjpgcom: can't open p7050955.jpg
rdjpgcom: can't open p7060994.jpg
rdjpgcom: can't open p7071035.jpg
rdjpgcom: can't open p7071037.jpg
rdjpgcom: can't open p7071038.jpg
Creating page: ./p7050911-1-0.html
Creating page: ./p7050915-1-0.html
Creating page: ./p7050916-1-0.html
Creating page: ./p7050917-1-0.html
Creating page: ./p7050919-1-0.html
Creating page: ./p7050924-1-0.html
Creating page: ./p7050925-1-0.html
Creating page: ./p7050927-1-0.html
Creating page: ./p7050928-1-0.html
Creating page: ./p7050930-1-0.html
Creating page: ./p7050932-1-0.html
Error : No such file
in file 'p7050934.jpg'
Use of uninitialized value in addition (+) at /usr/bin/cthumb line 1025.
Use of uninitialized value in join or string at /usr/bin/cthumb line 1218.
Use of uninitialized value in join or string at /usr/bin/cthumb line 1219.
Use of uninitialized value in concatenation (.) or string at /usr/bin/cthumb line 1226.
Use of uninitialized value in concatenation (.) or string at /usr/bin/cthumb line 1226.
Error : No such file
in file 'p7050934.jpg'
Creating page: ./p7050934-1-0.html
Creating page: ./p7050935-1-0.html
Error : No such file
in file 'p7050936.jpg'
Use of uninitialized value in addition (+) at /usr/bin/cthumb line 1025.
Use of uninitialized value in join or string at /usr/bin/cthumb line 1218.
[...]

The above happens when user deletes some files previously existing and therefore referenced from the cthumb album file (.lst in my case). Sometimes it is not convenient to re-create the album file for example when the file has been extensively edited as it contains description of the slides, etc. The perl script should simply skip those files which are missing but shouldn't crash every once.

Current cvs version has a number of fixes and works fine for me even in this case. I think it would be nice if you could checkout the cvs version and put it to ~x86 tree, actually to all testing trees as it is just a perl stuff. The developlment of cthumb is very moderate. While inspecting current bugreports at cthumb.sourcefoge.net I've made one patch which I'll attach afterwards (to be patched over current cvs checkout).

Comment 1 Martin Mokrejš 2006-02-23 13:35:23 UTC

Created attachment 80556 [details]
cthumb.in.patch

Comment 2 Alec Warner (RETIRED) archtester

2007-01-24 19:04:00 UTC

AFter some discussion with a few m-needed people we have decided to request that you take it upstream.  I'm unsure if they are still taking requests.  Indeed there are many alternative thumbnailers and gallery packages in the tree (imagemagick, llgal, igal etc..) that may be better than this thing.