| Summary: | mail-filter/clapf-0.3.23.ebuild (New package) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Anatoly Shipitsin <norguhtar> |
| Component: | New packages | Assignee: | Andrej Kacian (RETIRED) <ticho> |
| Status: | RESOLVED NEEDINFO | ||
| Severity: | enhancement | CC: | net-mail+disabled |
| Priority: | High | Keywords: | EBUILD |
| Version: | 2005.1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://clapf.acts.hu/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 123576 | ||
| Bug Blocks: | |||
| Attachments: |
clapf-0.3.23.ebuild
fix tinycdb depends change config file location clapf init script confd file |
||
|
Description
Anatoly Shipitsin
2006-02-20 23:32:18 UTC
Created attachment 80348 [details]
clapf-0.3.23.ebuild
Created attachment 80349 [details, diff]
fix tinycdb depends
Created attachment 80350 [details, diff]
change config file location
Created attachment 80351 [details]
clapf init script
Created attachment 80352 [details]
confd file
If i'm can add env variable TMP in init script, it's not need ;)
Let's give user the choice where does he want temporary files to be stored, as long as default value works. > Let's give user the choice where does he want temporary files to be stored, as
> long as default value works.
>
Okey.
Ok, some QA points:
Saying "${PN}-${PV}" is the same as saying "${P}"
S=${WORKDIR}/${P} is the default value of ${S}, thus can be omitted
Instead of gentoo-config.patch, you could just use sed to tweak the config file to your needs - for example, see app-antivirus/clamav ebuild.
Do not use spaces to indent lines (pkg_preinst() and pkg_postinst()), use tab(s) instead.
It's better to fix configure.in file to add required flags to LDFLAGS and CPPFLAGS and send the patch upstream, instead of overriding portage's LDD/CPPFLAGS.
You probably forgot to say $(use_enable mysql blackhole) in econf call. (I assume "blackhole" is a mysql-dependant feature.)
Do not get discouraged by this criticism, it's a common QA practice. If you need help with any of these issues, just say so, I'll be glad to help.
> Do not get discouraged by this criticism, it's a common QA practice. If you
> need help with any of these issues, just say so, I'll be glad to help.
Where i'm can read QA ?
There is currently a motion to have this kind of documentation in one central place. Meanwhile, try these URLs: Official: Development-related documentation at www.gentoo.org, most notably http://www.gentoo.org/proj/en/devrel/handbook/hb-guide-common-mistakes.xml Unofficial: http://dev.gentoo.org/~plasmaroo/devmanual/ http://dev.gentoo.org/~ciaranm/docs/ Thanks. I'm read this and recommit ebuild. Anatoly, are you planning to submit a rewritten ebuild? Closing due to inactivity. |
