Bug 123538 – adesklets 0.5.0-r1 ebuild (update)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description S.Fourmanoit 2006-02-20 13:50:01 UTC]

Find enclosed an updated version of the adesklets-0.5.0 ebuild included in the portage tree. This new ebuild:

- Adds support for the debug machinery of the adesklets interpreter
- Adds support for default redirection to the WM contextual menu
- Conditionally applies a Xorg-specific patch for smoother use under Xfce4.

It adds a local use flag, 'ctrlmenu'. Here is the proposed description for use.local.desc:

x11-misc/adesklets:ctrlmenu - force CTRL to be pressed to fire context menu

[Comment 1 S.Fourmanoit 2006-02-20 13:53:16 UTC]

Created attachment 80313 [details]
Updated ebuild for adesklets 0.5.0

[Comment 2 S.Fourmanoit 2006-02-20 13:55:08 UTC]

Created attachment 80314 [details, diff]
adesklets-ctrlmenu.patch

[Comment 3 Philip Kovacs 2006-02-20 17:51:01 UTC]

Created attachment 80331 [details]
adesklets-0.5.0-r1.ebuild

I've taken the liberty of making some minor changes to the ebuild and patch.   First, there's no need to conditionally apply the patch, since the new ctrlmenu use flag activate/deactivates that section of code implicitly.   The patch now has a version on it so it's clear to what version it belongs.   The patch file directory paths are fixed (src/adesklets) in next attachment.   Finally I will attach an ebuild diff as is recommended.  Phil

[Comment 4 Philip Kovacs 2006-02-20 17:51:53 UTC]

Created attachment 80332 [details, diff]
files/adesklets-0.5.0-ctrlmenu.patch

[Comment 5 Philip Kovacs 2006-02-20 17:52:26 UTC]

Created attachment 80333 [details, diff]
adesklets-0.5.0-r1.ebuild.diff

[Comment 6 Philip Kovacs 2006-02-20 18:04:26 UTC]

whoops.  corrections coming.

[Comment 7 Philip Kovacs 2006-02-20 18:12:55 UTC]

Created attachment 80334 [details]
adesklets-0.5.0-r1.ebuild

[Comment 8 Philip Kovacs 2006-02-20 18:13:41 UTC]

Created attachment 80335 [details, diff]
adesklets-0.5.0-r1.ebuild.diff

ok thats squares it all up

[Comment 9 S.Fourmanoit 2006-02-20 20:16:03 UTC]

I agree those changes are for the better, therefore I will mark my original attachments as obsoleted by the new ones from Philip.

One small detail: I find the "when patching src/adesklets.c or src/commands.c, you need to touch these files" comment slightly misleading... On most gentoo systems, you only need to touch them to save time, because it is shorter than calling configure twice, or with an --enable-maintainer-mode flag. Any gentoo system with bs, bash and GNU sed 4.x.x should be able to regenerate them.

[Comment 10 Philip Kovacs 2006-02-20 20:42:05 UTC]

Sylvain,

I only added that comment as a reminder that there is a "caveat" if you will when patching those two particular files, not as the last word on the subject.   If the tarball contains all the maintainer files, and you recommend that two configure passes be done, instead of this "trick" -- we can do that too.  

Phil

[Comment 11 S.Fourmanoit 2006-02-20 21:23:48 UTC]

Phil,

> you recommend that two configure passes be done, instead of this "trick" -- we 
> can do that too

oh - not at all: touching the two files is in fact a recommendable shortcut (why spending a significant amount of time regenerating files that do not need it?), and I understand why you wrote the comment. I am just suggesting that something similar to "when performing minor changes to src/adesklets.c or src/commands.c, touching these files will avoid unneeded processing" could withdraw a possible confusion.

[Comment 12 Philip Kovacs 2006-02-20 21:32:22 UTC]

Created attachment 80339 [details]
adesklets-0.5.0-r1.ebuild

Done!

[Comment 13 Philip Kovacs 2006-02-20 21:32:58 UTC]

Created attachment 80340 [details, diff]
adesklets-0.5.0-r1.ebuild.diff

Done!

[Comment 14 Michele Noberasco (RETIRED) 2006-02-24 01:58:41 UTC]

Let's see

[Comment 15 Michele Noberasco (RETIRED) 2006-02-24 02:24:28 UTC]

In Portage, thanks for the submission!