Bug 123124 – XMMS crashes when you attempt to exit FLAC configuration

• Product: Gentoo Linux
• Status: RESOLVED WONTFIX

[Description Phil Bordelon (sunflare) 2006-02-16 18:54:26 UTC]

XMMS crashes when you attempt to exit FLAC configuration.  (Wow, that seems
familiar!)

I can duplicate this with the stock FLAC compile, and it has nothing to do
with my particular system--this bug will be fixed in a newer version of
FLAC, which hasn't yet been released.  Part of this patch already exists
in the FLAC patches tbz2, but it's not enough to keep it from crashing.

Steps to Reproduce:

1. Open XMMS.
2. Go into configuration.
3. Pick FLAC plugin.
4. Click okay.

Fall down go boom!

Patch will be attached below; the problem is that GCC allocates static strings for the ""s and, while the first g_free() works, the next two explode because the string has already been freed.  Oops!  The fix just changes 'em to NULL pointers, which is The Right Thing.


Portage 2.0.54 (default-linux/x86/no-nptl/2.4, gcc-3.4.4, glibc-2.3.5-r2, 2.4.31 i686)
=================================================================
System uname: 2.4.31 i686 Intel(R) Pentium(R) 4 CPU 2.40GHz
Gentoo Base System version 1.6.14
ccache version 2.3 [enabled]
dev-lang/python:     2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.4.22-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=pentium4 -O3 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=pentium4 -O3 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/opt/portage-overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X aalib acl alsa apm audiofile avi berkdb bitmap-fonts bonobo bzip2 cdr crypt cups curl dga dvd eds emboss encode ethereal exif expat fam flac foomaticdb fortran gd gdbm gif glut gnome gpm gstreamer gtk gtk2 gtkhtml guile idn imagemagick imlib ipv6 java jpeg lcms ldap libg++ libwww lua mad mikmod mmx mng mozilla mp3 mpeg ncurses nls offensive ogg openal opengl oss pam pcre pdflib perl png python qt quicktime readline recode samba sdl slang spell sse sse2 ssl tcltk tcpd tiff truetype truetype-fonts type1-fonts unicode usb vorbis wmf xine xml xml2 xmms xv xvid zlib userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, MAKEOPTS

[Comment 1 Phil Bordelon (sunflare) 2006-02-16 18:56:00 UTC]

Created attachment 79978 [details, diff]
Patch to set values in config properly to keep from crashing.

This patch does what I describe above--it sets the values in the config properly to keep the XMMS plugin from crashing.

This supplants the patch in  xmms-patches.tbz2 that fixes one (but not all) instances of this string funkiness.

[Comment 2 Luis Medinas (RETIRED) 2006-02-20 16:12:24 UTC]

yes the patch looks good i'll commit asap.

[Comment 3 Jack Browning 2006-06-18 11:23:21 UTC]

(In reply to comment #2)
> yes the patch looks good i'll commit asap.

What is the status of this patch? r15 and r16 still exhibit this anomalous behavior. Just curious about the ETA for inclusion. TIA.

[Comment 4 Phil Bordelon (sunflare) 2006-07-14 15:37:37 UTC]

Any movement here?  This patch is known good ...

[Comment 5 Jakub Moc (RETIRED) 2006-10-23 00:47:33 UTC]

xmms and all plugins are now package.masked and will be removed from the tree in one month.

WONTFIX.