Summary: | sci-libs/comedilib-0.7.21 RUNPATH bug | ||
---|---|---|---|
Product: | Gentoo Security | Reporter: | MAL <mal> |
Component: | Runpath Issues | Assignee: | Gentoo Security <security> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | blg, caleb, lema, patrizio.bassi |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 81745 | ||
Attachments: |
fix rpath problem - comedilib-0.7.21
fix comedi_calibrate/Makefile.in to respect DESTDIR in install-data-local 2nd fix rpath problem - comedilib-0.7.21 |
Description
MAL
2006-02-16 09:33:38 UTC
The next ~arch portage revision will auto repair evil rpaths and not bail. Maintainers should still fix the packages they maintain as portage will only die with FEATURES=stricter (but that is a maintainer & QA problem) no longer security@ http://bugs.gentoo.org/show_bug.cgi?id=124962 same here. Created attachment 81688 [details]
fix rpath problem - comedilib-0.7.21
I think I have a fix. What seems to happen is that the autotools-based build uses $prefix to set the rpath of libcomedi.la when it is linked (with libtool). This path is used to set the rpath of comedi_calibrate et. al. during the 'make install' (which also uses libtool for install). The solution is to configure the package with --prefix=/usr and install it using DESTDIR=${D}. Note that the package still needs to be configured with --localstatedir=${D}/var because the automake-based makefile, comedi_calibrate/Makefile.am does not respect DESTDIR for the install-data-local target. Also, I have changed the 'make' command in src_compile() to 'emake || die'. HTH, Ben I have posted a bug at comedi.org about the target, install-data-local, not respecting DESTDIR. https://bugzilla.comedi.org/cgi-bin/bugzilla/show_bug.cgi?id=213 yeah, this ebuild's src_compile is way broken the updated ebuild should also *not* pass $D to configure ... patch the makefiles, dont hack configure Created attachment 81698 [details, diff] fix comedi_calibrate/Makefile.in to respect DESTDIR in install-data-local (In reply to comment #6) > yeah, this ebuild's src_compile is way broken > > the updated ebuild should also *not* pass $D to configure ... patch the > makefiles, dont hack configure > Definitely. I realize that passing ${D} to configure _is bad_; however, the option --localstatedir is considered only by one target in one makefile and the target in an install hook. The whole subdir is phased out in the CVS version; so it's not a big deal to 'hack' ./configure. But you're the boss: Here is a patch for the makefile. Created attachment 81699 [details]
2nd fix rpath problem - comedilib-0.7.21
updated the ebuild to stop passing ${D} to configure and apply the above patch
thanks, patches/ebuilds look good to me ... up to the maintainer to update the tree now he's right - that's me. fix works, can you commit to cvs? removed comedi, and as such have removed comedilib from portage. |