Bug 122256 – sys-apps/eject-2.1.0 toggle bug

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Stuart W. Finlayson 2006-02-09 07:46:58 UTC]

Toggling the tray when the media is mounted results in an I/O error:

wolverine ~ # mount -v /mnt/cdrom
/dev/hdd on /mnt/cdrom type iso9660 (ro,noexec,nosuid,nodev)
wolverine ~ # eject -T /mnt/cdrom
ioctl: Input/output error
wolverine ~ #

This is because the section that handles the -T option is misplaced.  It should occur after the device is unmounted, otherwise it will not eject.  See attached patch.


wolverine ~ # emerge --info
Portage 2.0.54 (default-linux/x86/2005.1, gcc-3.4.4, glibc-2.3.5-r2, 2.6.15.1 i686)
=================================================================
System uname: 2.6.15.1 i686 Intel(R) Pentium(R) 4 CPU 3.00GHz
Gentoo Base System version 1.6.14
dev-lang/python:     2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r3
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=pentium4 -O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/bind /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=pentium4 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig candy distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://mirror.datapipe.net/gentoo http://gentoo.seren.com/gentoo http://open-systems.ufl.edu/mirrors/gentoo"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="x86 X aalib alsa apm arts audiofile avi bash-completion bitmap-fonts bzip2 bzlib cdr crypt curl dvd dvdr eds emboss encode esd ethereal exif expat fam ffmpeg flac fortran gif glut gmp gpm idn imlib ipv6 java jpeg kde kdeenablefinal lcms libwww mad mikmod mmx mmx2 mng motif mp3 mpeg ncurses network nptl nptlonly ogg oggvorbis opengl oss pam pcre pdflib perl png python qt quicktime readline rtc sdl slang spell sse sse2 ssl svga tcpd tetex tiff truetype truetype-fonts type1-fonts udev vorbis xine xml2 xmms xv xvid zlib userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTDIR_OVERLAY

[Comment 1 Stuart W. Finlayson 2006-02-09 07:47:45 UTC]

Created attachment 79327 [details, diff]
Patch that fixes toggle problem

[Comment 2 SpanKY 2006-02-09 20:55:07 UTC]

*** Bug 106487 has been marked as a duplicate of this bug. ***

[Comment 3 SpanKY 2006-02-09 20:55:55 UTC]

Patrik: think you could do me a favor and review this patch for me ?

[Comment 4 Patrik Kullman 2006-02-10 13:24:51 UTC]

Stuart is right of course.
We didn't think it through properly.

It should be committed and also sent upstream.
Too bad our original patch went upstream for 2.1 without this change ;/

[Comment 5 Stuart W. Finlayson 2006-02-10 19:40:34 UTC]

I already submitted it to Jeff, it's in CVS, and should be in the next stable version (2.1.5).

[Comment 6 SpanKY 2006-02-10 20:16:13 UTC]

added to eject-2.1.0-r1 then, thanks all

[Comment 7 Stuart W. Finlayson 2006-02-10 22:28:39 UTC]

The patch was added, but isn't applied by the ebuild.

[Comment 8 SpanKY 2006-02-10 22:35:10 UTC]

indeed, fixed in cvs