Bug 122002 – mserver 0.5.5 fails (gcc4)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Patrizio Bassi 2006-02-07 09:08:45 UTC]

another porting problem due to gcc 4

reating fakelink/Makefile
creating firewallscripts/Makefile
creating firewallscripts/ipchainscripts/Makefile
creating firewallscripts/ipfwadmscripts/Makefile
creating initscripts/Makefile
creating mchat/Makefile
creating mserver/Makefile
creating config.h
cd . && autoheader
configure.in:85: warning: AC_TRY_RUN called without default to allow cross compiling
make  all-recursive
make[1]: Entering directory `/var/tmp/portage/mserver-0.5.5-r1/work/mserver-0.5.5'
Making all in authgen
make[2]: Entering directory `/var/tmp/portage/mserver-0.5.5-r1/work/mserver-0.5.5/authgen'
gcc -DHAVE_CONFIG_H -I. -I. -I..     -O2 -Wall   -c authgen.c
authgen.c: In function ‘main’:
authgen.c:77: error: invalid lvalue in assignment
authgen.c: In function ‘chomp’:
authgen.c:98: warning: implicit declaration of function ‘strlen’
authgen.c:98: warning: incompatible implicit declaration of built-in function ‘strlen’
make[2]: *** [authgen.o] Error 1
make[2]: Leaving directory `/var/tmp/portage/mserver-0.5.5-r1/work/mserver-0.5.5/authgen'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/mserver-0.5.5-r1/work/mserver-0.5.5'
make: *** [all-recursive-am] Error 2

!!! ERROR: net-dialup/mserver-0.5.5-r1 failed.
Call stack:
  ebuild.sh, line 1894:   Called dyn_compile
  ebuild.sh, line 941:   Called src_compile

!!! (no error message)
!!! If you need support, post the topmost build error, and the call stack if relevant.

[Comment 1 Alin Năstac (RETIRED) 2006-02-07 22:00:56 UTC]

can you find the proper mserver-0.5.5-gcc4.patch?

removing cast operators from line 77 of the authgen.c file should fix the error. 
in addition, you should include string.h file as well.

[Comment 2 Patrizio Bassi 2006-02-08 00:19:34 UTC]

sorry where the patch is?

[Comment 3 Alin Năstac (RETIRED) 2006-02-08 00:27:04 UTC]

I'm asking you to make a patch that fixes compilation problems on gcc-4.

[Comment 4 Patrizio Bassi 2006-02-08 01:22:10 UTC]

i'm not the mainteiner and howerver the problem is not that only...

In file included from mserver.c:34:
mserver.h:154: error: array type has incomplete element type
mserver.h:154: error: array type has incomplete element type
mserver.c: In function ‘main’:
mserver.c:134: error: type of formal parameter 2 is incomplete
mserver.c:134: error: type of formal parameter 3 is incomplete
mserver.c:227: warning: pointer targets in passing argument 3 of ‘accept’ differ in signedness
make: *** [mserver.o] Error 1

i'll take a look but you should ask upstream and the mainteneir before asking a simple user :)

[Comment 5 Alin Năstac (RETIRED) 2006-02-08 02:25:12 UTC]

1) upstream is dead
2) I don't have gcc-4 installed on my system so it is harder for me than for you to test the solution for this bug.
3) usually gentooers help us. besides, I'm only asking, I don't point a gun to your head. if you don't want/know how to help, just don't do it.

[Comment 6 Patrizio Bassi 2006-02-08 02:45:21 UTC]

1. bad.. bad..
2. no problem
3. i use to contrib, but i was really busy. sorry if it seemed to you i was bad mood, wasn't like that :)

however...here is the gcc4 patch.

enjoy :)))

[Comment 7 Patrizio Bassi 2006-02-08 02:45:45 UTC]

Created attachment 79211 [details, diff]
gcc4 patch

gcc4 patch

[Comment 8 Alin Năstac (RETIRED) 2006-02-08 10:30:18 UTC]

fixed in mserver-0.5.5-r2. thanks!