Bug 121992

Summary:	app-office/openoffice-2.0.1 compile fix for gcc-4.1.x users
Product:	Gentoo Linux	Reporter:	Priit Laes (IRC: plaes) <plaes>
Component:	Current packages	Assignee:	Gentoo Office Team <office>
Status:	RESOLVED FIXED
Severity:	normal	CC:	h.mth
Priority:	High
Version:	2005.1
Hardware:	All
OS:	Linux
URL:	http://forums.gentoo.org/viewtopic-t-402539-postdays-0-postorder-asc-start-450.html
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	117482
Attachments:	store-drop-gcc-libs-on-linking.diff gcc-4.1.x-nptlonly-tls-fix.diff openoffice-2.0.1.ebuild.diff

Description Priit Laes (IRC: plaes) 2006-02-07 08:15:39 UTC

Compiling openoffice-2.0.1 with gcc-4.1 compiler on the nptlonly glibc results in compile error.

Patches coming.

Comment 1 Priit Laes (IRC: plaes) 2006-02-07 08:16:37 UTC

Created attachment 79125 [details, diff]
store-drop-gcc-libs-on-linking.diff

Patch from ooo-build.

Comment 2 Priit Laes (IRC: plaes) 2006-02-07 08:17:42 UTC

Created attachment 79126 [details, diff]
gcc-4.1.x-nptlonly-tls-fix.diff

Patch against to get it automatically patch the sources.

Comment 3 Priit Laes (IRC: plaes) 2006-02-07 08:20:57 UTC

Created attachment 79127 [details, diff]
openoffice-2.0.1.ebuild.diff

Patch against ebuild. At the moment it's untested, but openoffice is currently emerging and has already passed the point of breakage.

To avoid regressions, we should check whether glibc was built with nptlonly USE flag, but hopefully it works :)

Comment 4 Hanno Zysik (geki) 2006-02-15 04:59:58 UTC

My initial hack just drops the gcc check in store/util/makefile.mk.
(.IF "$(COMID)"=="gcc3")

The real fix is to change $(COMID) to gcc4 if gcc4.x is used.
If I am not mistaken.

I will have a look into this and supply a patch then.

Comment 5 Hanno Zysik (geki) 2006-02-16 04:07:14 UTC

Touching $(COMID) ends in a deep impact of OOo build procedure.
No way I touch that. :)

new version on ooo-build-HEAD:
http://go-oo.org/patches/src680/store-drop-gcc-libs-on-linking.diff

ChangeLog:
	* patches/src680/store-drop-gcc-libs-on-linking.diff: replace hack by
	additional gcc version check, add '-lsupc++ -lgcc_s' only for < gcc 4.1

Comment 6 Priit Laes (IRC: plaes) 2006-02-17 07:22:08 UTC

This is still needed for app-office/openoffice-2.0.2_rc1

Comment 7 Priit Laes (IRC: plaes) 2006-02-28 23:34:48 UTC

...and still needed with app-office/openoffice-2.0.2_rc3.

Comment 8 Andreas Proschofsky (RETIRED) gentoo-dev

2006-03-01 10:05:15 UTC

I've just added a new revision to portage which utilizes Hannos Hack for fixing this. Could you please try out and see how it goes?

Comment 9 Priit Laes (IRC: plaes) 2006-03-01 23:01:05 UTC

Works for me :)

Marking fixed..