Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 120769

Summary: ebuild for media-libs/tunepimp 0.4.2
Product: Gentoo Linux Reporter: Almad <bugs>
Component: New packagesAssignee: Gentoo KDE team <kde>
Status: RESOLVED FIXED    
Severity: enhancement CC: cgibreak, gentoo, hakan, matrixhax0r, max, rabbitambulance
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: taglib patch
tunepimp-0.4.2 ebuild
ebuild for 0.5.0_alpha1

Description Almad 2006-01-28 15:26:18 UTC
New tunepimp has been released!
http://blog.musicbrainz.org/archives/2006/01/releases_picard_2.html
Comment 1 Peter Gantner (a.k.a. nephros) 2006-01-28 22:18:56 UTC
Did a quick compiletest:
Looks like simply bumping the ebuild works, if you remove the epatch line.

Though configure shows a "will not compile with TAGLIB support" line, maybe a USE flag and config setup is needed in the ebuild. Will look into it later today when I find the time.
Comment 2 Peter Gantner (a.k.a. nephros) 2006-01-29 09:18:09 UTC
The configure output is thus:

checking for taglib-config... /usr/bin/taglib-config
checking for taglib >= 1.4.0... no
*** NOT compiling TagLib support

which is funny, because the upstream version of taglib is 1.4 and there is no later version, .0 or other:
# taglib-config --version
1.4

I made a patch for the configure script therefore so it just looks for 1.4. This is found and used then.

ebuild and patch attached.
Comment 3 Peter Gantner (a.k.a. nephros) 2006-01-29 09:18:59 UTC
Created attachment 78439 [details, diff]
taglib patch
Comment 4 Peter Gantner (a.k.a. nephros) 2006-01-29 09:19:51 UTC
Created attachment 78440 [details]
tunepimp-0.4.2 ebuild
Comment 5 Peter Gantner (a.k.a. nephros) 2006-01-31 07:57:14 UTC
Blech! This breaks kdemultimedia unfortunately. revdep-rebuild wants to remerge kdemultimedia after installing this, resulting in:

Making all in pics
ktrm.cpp: In member function `int KTRMRequestHandler::startLookup(KTRMLookup*)':
/usr/include/tunepimp/tp_c.h:645: error: too few arguments to function `int tp_AddFile(void*, const char*, int)'
ktrm.cpp:69: error: at this point in file
ktrm.cpp: In constructor `KTRMRequestHandler::KTRMRequestHandler()':
ktrm.cpp:123: error: `tp_SetUseUTF8' undeclared (first use this function)
ktrm.cpp:123: error: (Each undeclared identifier is reported only once for each function it appears in.)
ktrm.cpp:124: error: invalid conversion from `void (*)(void*, void*, TPCallbackEnum, int)' to `void (*)(void*, void*, TPCallbackEnum, int, TPFileStatus)'
ktrm.cpp:124: error:   initializing argument 2 of `void tp_SetNotifyCallback(void*, void (*)(void*, void*, TPCallbackEnum, int, TPFileStatus), void*)'
ktrm.cpp: In member function `virtual void KTRMLookup::collision()':
ktrm.cpp:506: error: base operand of `->' has non-pointer type `artistresult_t'
ktrm.cpp:507: error: base operand of `->' has non-pointer type `albumresult_t'
ktrm.cpp:509: error: base operand of `->' has non-pointer type `albumresult_t'
make[3]: *** [ktrm.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

!!! ERROR: kde-base/kdemultimedia-3.5.0 failed.

Looks simple to fix but I don't know enough C(++) to do that.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-01-31 09:23:57 UTC
That's why tunepimp 0.4 is currently masked, also amaroK breaks with it.
Comment 7 Maxwell Grender-Jones 2006-03-13 02:10:37 UTC
in that case, can we slot tunepimp?
Comment 8 Maxwell Grender-Jones 2006-03-13 13:38:18 UTC
Created attachment 82034 [details]
ebuild for 0.5.0_alpha1

Anyhoo, here's an ebuild for the latest and greatest version of tunepimp, complete with PUid generation. Thought I'd put it here so that hackers can get started.

N.B. Doesn't look like the perl or python bindings have been updated yet, but the python bindings haven't ever worked afaict (sure the demo works, but can you actually query the server for tracks?)

fwiw the project is looking a lot more positive now, and the new python bindings are great.
Comment 9 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-05-21 16:09:57 UTC
Adding 0.4.2 version right now, although not slotted. I'll be trying to fix kid3 and juk that requires tunepimp 0.3 and then see to unmask this.