Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 120752

Summary: www-servers/tomcat-5.0.28-r12 should not require dev-java/struts
Product: Gentoo Linux Reporter: Mike Slinn <mslinn>
Component: New packagesAssignee: Java team <java>
Status: RESOLVED INVALID    
Severity: normal CC: alonbl, gfernandez, wltjr
Priority: High    
Version: unspecified   
Hardware: x86   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Mike Slinn 2006-01-28 11:21:38 UTC
Not everyone who uses tomcat wants or needs struts.  tomcat-5.0.28-r12.ebuild has added a dependency on struts - but struts is not required for tomcat's operation - it is a framework that builds on top of Java servlet containers.

Line 35 of the ebuild (/usr/portage/www-servers/tomcat/tomcat-5.0.28-r12.ebuild) should be commented out or deleted:
=dev-java/struts-1.1-r4
Comment 1 Josh Nichols (RETIRED) gentoo-dev 2006-01-28 12:17:03 UTC
If I'm not mistaken, some of the example webapps use struts, which is where the dependency come from.

Additionally, struts builds on the servlet api, not the container. The serlet api is provided by a sepearate package, servletapi, which was gleaned out of tomcat. If struts dependend on tomcat, and tomcat on struts, then that would be a problem, but I believe that was one of the motivations between separating out servletapi to a separate package.
Comment 2 Mike Slinn 2006-01-28 12:49:03 UTC
The struts dependency was recently added.  I don't know if the examples in older ebuilds required struts or not, but tomcat-5.0.27-r5.ebuild does not depend on struts.  A large percentage of Tomcat installations do not require struts.  No point in installing the extra package, especially for a production system.

Perhaps a struts use flag, defaulting to off, is the solution.
Comment 3 William L. Thomson Jr. (RETIRED) gentoo-dev 2006-04-06 17:51:13 UTC
tomcat-5.0.28-r12 MUST depend on struts in order to compile Tomcat. It's not even considered an optional package with regard to installation. The addition of the dependency is a result of compiling Tomcat from source. Please see Tomcat's build.properties.default for Struts inclusion.
Comment 4 Josh Nichols (RETIRED) gentoo-dev 2006-04-06 17:53:11 UTC
Marking as invalid, because struts is a real dependency.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2006-05-19 03:17:43 UTC
*** Bug 133763 has been marked as a duplicate of this bug. ***
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2006-09-04 23:59:29 UTC
*** Bug 146349 has been marked as a duplicate of this bug. ***