Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 120374

Summary: repoman - DEPEND validation "use? || (...)" should be detected as invalid
Product: Portage Development Reporter: Robin Johnson <robbat2>
Component: RepomanAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: 2.1   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 335925    

Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-01-25 22:01:22 UTC
Bugging this for antarus.

I ran into this while doing modular-x fixes. It should probably be fixed in either emerge OR repoman.

"useflag? || ( pkga pkgb )"
doesn't work. See xemacs-21.4.17.ebuild r1.1 for an example - it brings in virtual/x where it shouldn't.

however the correct form of "useflag? ( || ( pkga pkgb ) )" does work fine.

Either repoman needs to detect the bad case, or emerge needs to behave correctly when it sees it.
Comment 1 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-02-07 21:10:54 UTC
Just to post an update, the check for this is basically written, however it uses a new parser to check DEPEND syntax, and I need a bit of time to integrate it into repoman.
Comment 2 Zac Medico gentoo-dev 2010-09-13 17:18:50 UTC
This is fixed in 2.1.9 and there's a test case here:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=ee36efb132157192655753c53dbd1c78c74d4a58