| Summary: | media-plugins/vcf - LADSPA plugins | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Benjamin Tremoulheac <gentoo> |
| Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
| Status: | CONFIRMED --- | ||
| Severity: | enhancement | CC: | sound, tcort |
| Priority: | High | Keywords: | EBUILD |
| Version: | 2005.1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.suse.de/~mana/ladspa.html | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
vcf-0.0.5.ebuild
vcf-0.0.5.ebuild vcf-0.0.5.ebuild vcf-0.0.5.ebuild |
||
|
Description
Benjamin Tremoulheac
2006-01-23 13:10:16 UTC
Created attachment 77946 [details]
vcf-0.0.5.ebuild
Simple ebuild for vcf-0.0.5.
Created attachment 77947 [details]
vcf-0.0.5.ebuild
Corrected licence.
- LGPL is not a valid license, please have a look at /usr/portage/licenses - did you test on all the keyworded architectures, ~arch please - looks like src_compile() is superfluous > /usr/lib/ladspa Your ebuild should not hardcode the lib directory because it breaks multilib. Instead you should use $(get_libdir) from the multilib eclass. So, you should change /usr/lib/ladspa to something like /usr/$(get_libdir)/ladspa. See this page for details on multilib: http://dev.gentoo.org/~plasmaroo/devmanual/archs/amd64/#the-multilib-strict-feature Thanks for submitting the ebuild and continuing to improve upon it. Created attachment 79679 [details]
vcf-0.0.5.ebuild
Corrected ebuild. Why src_compile() is superfluous ?
(In reply to comment #5) > Why src_compile() is superfluous ? If all your src_compile does is run econf and then emake (or just emake, or even does nothing at all), you can omit it. See: http://dev.gentoo.org/~plasmaroo/devmanual/ebuild-writing/functions/src_compile/ > KEYWORDS="~alpha ~amd64 ~ppc ~sparc x86" Have you really tested this on all of those platforms? You should only include keywords for archs on which you have tested. There are no exceptions for "stuff that is obviously cross platform", "stuff that upstream says works on other platforms" or "stuff that should be tested on other platforms". If you include anything other than ~x86 and ~amd64 in KEYWORDS, drop a comment in the bug saying "yes, I really have tested this on $arch" (and note that even if you *have*, the arch teams will still need to give the okay). > KEYWORDS="~alpha ~amd64 ~ppc ~sparc x86" Using arch (eg x86) rather than ~arch (eg ~x86). New packages start off in ~arch. There are no exceptions for stuff that is "really simple", "obviously stable" or "working". Created attachment 79695 [details]
vcf-0.0.5.ebuild
Hope it's alright now...
This package has no maintainer so this bug may go unnoticed for a long time. Gentoo has a dedicated team[1] for assisting users in maintaining orphaned packages. If you are interested in maintaining this package, please contact proxy-maint@gentoo.org. [1]: http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml |
