| Summary: | Version bump for wormux | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Ruud Althuizen <ruud> |
| Component: | [OLD] Games | Assignee: | Gentoo Games <games> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | aokmanga, brebs, fcoiffie, follettoonip, tom.gl, victor.stinner, voyageur |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.wormux.org/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
wormux-0.7_beta1.ebuild
wormux-0.7_beta3.ebuild wormux-0.7_beta3.ebuild files/wormux-0.7_beta3-fix-gettext-Makefile.patch wormux-0.7_beta3.ebuild wormux-0.7_beta3.ebuild wormux-0.7_beta3-gcc41.patch wormux-0.7.ebuild files/wormux-0.7-fix-gettext-Makefile.patch files/wormux-0.7-gcc41.patch files/wormux-0.7-user-CFLAGS.patch |
||
|
Description
Ruud Althuizen
2006-01-18 08:14:19 UTC
Created attachment 77429 [details] wormux-0.7_beta1.ebuild Ebuild taken from their site http://www.wormux.org/wiki/en/download.php#Packages_.2F_distros You need to set the number of jobs to zero, I had a problem with -j2. Only tried to emerge it enabled once though. let me know when it's out of beta. Created attachment 77988 [details]
wormux-0.7_beta3.ebuild
Here is the ebuild i've been using here since beta1. As mentioned above, -jN doesn't work (breaks in po/), hence the simple "make" for compilation (would it be better to still use "emake", but with some MAKEOPTS filtering?).
Also, i've seen that despite --disable-nls, it won't compile without gettext installed, and thus i've not used the "nls" flag. Other than that, the "--datadir=..." option is here to fix both the data and locales installation paths, and the rest is pretty obvious.
Use emake -j1 if it breaks on parallel builds (or even better, patch the sources/Makefile). > Use emake -j1 if it breaks on parallel builds Ok, thanks for the advice, i will do that next time. > (or even better, patch the sources/Makefile). I was not big on hacking this Makefile, since it's one which comes directly from upstream's gettext version, but sure, that's doable. I will attach a patch+ebuild which does the following: - to workaround the "-jN" issue, it drops the rule which was doing the faulty make recursion. It's not that ugly since it's a timestamp checking rule, which should not be really useful when using some release tarball (would be different on some CVS sources sure). - in addition, it drops the .gmo compilation when using --disable-nls, so that the gettext dependency can be made optionnal (and thus i've reintroduced the USE flag). Created attachment 78001 [details]
wormux-0.7_beta3.ebuild
Created attachment 78002 [details, diff]
files/wormux-0.7_beta3-fix-gettext-Makefile.patch
*** Bug 122160 has been marked as a duplicate of this bug. *** Created attachment 79256 [details]
wormux-0.7_beta3.ebuild
I've extended the dependency list.
Created attachment 79259 [details]
wormux-0.7_beta3.ebuild
I've removed my bogus dependency on lib-compat.
> I've extended the dependency list.
I may be wrong, but it seems to me that you've added everything you've found in `ldd wormux` to the deps list. That's really not a good idea: most of them are deep deps, and are simply there for instance because of your USE flags on libsdl, or things like that. But they are not actually directly required by Wormux.
You're right - I suppose my deps are overkill, although I don't know how to be sure. I'm finding dependencies to be one of the blackest arts of ebuilds :) Comment on attachment 79259 [details]
wormux-0.7_beta3.ebuild
Sorry for my noise today - TGL's ebuild is superior anyway (I should have checked things more carefully), so I'm marking mine obsolete.
Emerges correctly on my system. Would anybody please add a wormux.desktop file. (In reply to comment #15) > Emerges correctly on my system. Would anybody please add a wormux.desktop file. > Good idea. Simply add this two lines to src_install(): newicon data/wormux-32.xpm wormux.xpm make_desktop_entry wormux wormux wormux.xpm *** Bug 124048 has been marked as a duplicate of this bug. *** *** Bug 125398 has been marked as a duplicate of this bug. *** Created attachment 82631 [details, diff]
wormux-0.7_beta3-gcc41.patch
Fix compilation with gcc-4.1.
(Just attaching this patch in case there are some gcc4 users around, but anyway this was already fixed upstream, so it won't be needed for 0.7-final.)
Version 0.7 is out. I will attach a new ebuild, with some minor changes (compared to the one for beta3), and some updated patches. Could someone (Ruud, or some dev) reopen this bug please? Thanks. Created attachment 83924 [details]
wormux-0.7.ebuild
Created attachment 83925 [details, diff]
files/wormux-0.7-fix-gettext-Makefile.patch
Same patch as before, just renamed.
Created attachment 83927 [details, diff]
files/wormux-0.7-gcc41.patch
Fixes several "extra qualification" errors, and also removes a few "assert(iterator != NULL)" (for this ones, you only see the error if compiling with USE=debug).
Created attachment 83928 [details, diff]
files/wormux-0.7-user-CFLAGS.patch
This is to avoid ./configure script changing the user-defined C(XX)FLAGS "-Olevel", or adding its own "-g" for debug. Not sure what the policy is on this topic though, so feel free to drop this patch if you think it's wrong.
Reopened on request. Have these patches been sent upstream? In portage. Thanks for the bug report, ebuild and patches. (In reply to comment #26) > Have these patches been sent upstream? I've only sent the gcc-4.1 patch (got no answer so far, but it was less than 24H ago). The patch for po/Makefile.in, well, it's just a workaround, so i won't send it as-is. But i will have a look later at what could be a proper fix for upstream. As for the one about respecting user's CFLAGS, it doesn't really fix a bug, but more a feature i don't like, so imho there's no point sending it upstream. (In reply to comment #27) > In portage. Thanks for the bug report, ebuild and patches. Thanks for the quick commit ;) Doesn't work here, the game fails just after start with a [ Run game ] *** glibc detected *** /usr/games/bin/wormux: free(): invalid pointer: 0x08114310 *** emerge --info: Portage 2.1_pre7-r4 (default-linux/x86/2005.0, gcc-4.1.0, glibc-2.4-r1, 2.6.16-mm1-ubik i686) ================================================================= System uname: 2.6.16-mm1-ubik i686 Intel(R) Pentium(R) M processor 1.70GHz Gentoo Base System version 1.12.0_pre16 dev-lang/python: 2.3.5-r2, 2.4.2 sys-apps/sandbox: 1.2.12 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2 sys-devel/binutils: 2.16.1-r2 sys-devel/libtool: 1.5.22 virtual/os-headers: 2.6.11-r2 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-O2 -mtune=i686 -fomit-frame-pointer" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /usr/share/X11/xkb /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/eselect/compiler /etc/gconf /etc/splash /etc/terminfo /etc/texmf/web2c /etc/env.d" CXXFLAGS="-O2 -mtune=i686 -fomit-frame-pointer" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig cvs distlocks metadata-transfer sandbox sfperms sign strict" GENTOO_MIRRORS="http://ftp.rhnet.is/pub/gentoo http://mirror.gentoo.no http://gentoo.mirror.sdv.fr ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/home/heimdall/gentoo/gentoo-x86" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="x86 X aac aalib acpi alsa asf audiofile avi bash-completion berkdb bitmap-fonts cjk crypt cups dlloader doc dri dvd dvdr dvdread eds emboss encode esd fbcon ffmpeg flac font-server foomaticdb fortran gdbm gif gimpprint glitz glut gnome gpm graphviz gstreamer gtk gtk2 icecast imap imlib isdnlog jpeg lcms libcaca libg++ libwww mad mbox mikmod mmx motif mozsvg mp3 mpeg musepack musicbrainz ncurses networkcanna nls nntp nptl nptlonly objc offensive ogg oggvorbis opengl pam pcre pdflib perl png pppd python quicktime radeon readline real sasl sdl softmmu spell sse sse2 ssl svg tcpd tiff truetype truetype-fonts type1-fonts unicode userlocales v4l vidix vorbis win32codecs wma xml2 xmms xv xvid zlib elibc_glibc kernel_linux userland_GNU" Unset: ASFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, LINGUAS, MAKEOPTS open a new bug. this one's about version bumping. Thanks. Thanks TGL for your bug report. We already fixed some bugs like that. Your patch is commited in "upstream". TGL: next time, please use mailing list to communicate. But thanks again to send us your patches, that's very important (in free softwares) ;-) gettext patch looks to be Gentoo specific. "...-user-CFLAGS.patch" also looks to be Gentoo specific, because most people don't set their own gcc flags, and it's very useful for us (developers) to use -O0 in development mode. Haypo, a Wormux developer Haypo - I think if you look at the autotools docs that it mentions that messing with the user's CFLAGS is bad form. Please reconsider accepting the patch related to the CFLAGS. I am playing wormux 0.7 beta3 on amd64, please mark ~amd64. thanks |
