Bug 117827 – libreadline should be optional in physfs

• Product: Gentoo/Alt
• Status: RESOLVED WONTFIX

[Description Aaron 2006-01-04 20:33:11 UTC]

libreadline should be made optional in physfs. (USE flag).

it should be made optional, because if it is disabled, it will compile in osx
if it is enabled (default), it will not compile in osx.

to my knowledge, physfs still works fine. (testing lincity-ng which uses physfs)

[Comment 1 Aaron 2006-01-04 20:34:42 UTC]

Created attachment 76211 [details, diff]
this is my proposed ebuild patch to physfs

should libreadline be added to DEPEND when the use flag is set?

[Comment 2 Fabian Groffen 2006-01-05 04:17:33 UTC]

For sure.  If you depend on readline, you need to have it installed.  And if you only depend on it with a USE-flag, then that depend should be conditional as well.

Which version of physfs are you working with?

The versions I see, don't have such dependency, hence I wonder why is this a problem at all?  Doesn't configure figure out there is no (or insufficient) readline support on OSX?

CC-ing games herd as they might have some input on this as well.

[Comment 3 Aaron 2006-01-05 08:16:24 UTC]

dev-games/physfs-1.0.1

configure detects a version of libreadline installed, but the installed version is insufficient. (linker errors with _add_history and _readline).

[Comment 4 Kito (RETIRED) 2006-01-05 08:38:58 UTC]

Its finding libedit....

[Comment 5 Fabian Groffen 2006-01-05 10:25:40 UTC]

I don't think the ebuild has to be fixed.  Configure should do a more extensive test, but Apple was wrong by symlinking libedit to libreadline too, IMHO.  So it's a bit of a nasty problem.

[Comment 6 SpanKY 2006-01-07 01:02:53 UTC]

not really

the only functions used are add_history() and readline(), both of which configure.in looks for in libreadline

[Comment 7 Fabian Groffen 2008-03-03 19:43:47 UTC]

in prefix this problem is non-existent.