Bug 116977

Summary:	poppler-0.4.3 doesn't compile against gcc-4.1
Product:	Gentoo Linux	Reporter:	Stéphane Gimenez <gentoo>
Component:	[OLD] GCC Porting	Assignee:	Printing Team <printing>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halcy0n, vapier
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch for poppler-0.4.3 to compile against gcc-4.1

Description Stéphane Gimenez 2005-12-28 06:39:19 UTC

hi, here comes the patch...
(can you repport this upstream ?)
thanks.

Comment 1 Stéphane Gimenez 2005-12-28 06:41:06 UTC

Created attachment 75673 [details, diff]
patch for poppler-0.4.3 to compile against gcc-4.1

Comment 2 SpanKY gentoo-dev

2005-12-28 13:25:16 UTC

normally we prefer the authors of patches to send their work upstream so they get proper credit ;)

Comment 3 Stéphane Gimenez 2005-12-28 14:49:33 UTC

Yep, that would be a shame to loose credit for such a /hard/ work ;)

I talked with upstream, and in fact my patch applies to some line inside files/poppler-0.4.3-utils.patch. Their cvs now includes pdftohtml but my problem was already fixed there. So upstream is clean.

Then the correct workaround is too append my patch to the existing files/poppler-gcc41.patch assuming it is applied after the other one (which by the way seems quite big for a portage-tree patch).

hope this helps

Comment 4 SpanKY gentoo-dev

2005-12-28 20:56:52 UTC

thanks, as long as upstream is fixed, i'm happy :)

added patch to cvs